Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936438AbcKNSiY (ORCPT ); Mon, 14 Nov 2016 13:38:24 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38806 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbcKNSiT (ORCPT ); Mon, 14 Nov 2016 13:38:19 -0500 Date: Mon, 14 Nov 2016 13:38:16 -0500 (EST) Message-Id: <20161114.133816.496728461078906675.davem@davemloft.net> To: tremyfr@gmail.com Cc: jcliburn@gmail.com, chris.snook@gmail.com, jarod@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: atheros: atl1: use new api ethtool_{get|set}_link_ksettings From: David Miller In-Reply-To: <1479058514-22438-1-git-send-email-tremyfr@gmail.com> References: <1479058514-22438-1-git-send-email-tremyfr@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Nov 2016 09:38:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 452 Lines: 14 From: Philippe Reynes Date: Sun, 13 Nov 2016 18:35:14 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > The previous implementation of set_settings was modifying > the value of advertising, but with the new API, it's not > possible. The structure ethtool_link_ksettings is defined > as const. > > Signed-off-by: Philippe Reynes Applied.