Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936497AbcKNTdJ (ORCPT ); Mon, 14 Nov 2016 14:33:09 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37917 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933841AbcKNTdG (ORCPT ); Mon, 14 Nov 2016 14:33:06 -0500 Subject: Re: [PATCH v2 1/2] mfd: pm8xxx: add support to pm8821 To: Stephen Boyd , Lee Jones References: <1479145933-9849-1-git-send-email-srinivas.kandagatla@linaro.org> Cc: bjorn.andersson@linaro.org, Rob Herring , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Srinivas Kandagatla Message-ID: <0a94fa12-5587-9c89-fc33-1a6f0b20e3a2@linaro.org> Date: Mon, 14 Nov 2016 19:33:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 25 On 14/11/16 18:40, Stephen Boyd wrote: > On 11/14/2016 09:52 AM, Srinivas Kandagatla wrote: >> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c >> index 7f9620e..dc347d3 100644 >> --- a/drivers/mfd/qcom-pm8xxx.c >> +++ b/drivers/mfd/qcom-pm8xxx.c >> + >> +static void pm8821_irq_handler(struct irq_desc *desc) >> +{ >> + struct pm_irq_chip *chip = irq_desc_get_handler_data(desc); >> + struct irq_chip *irq_chip = irq_desc_get_chip(desc); >> + unsigned int master; >> + int ret; >> + >> + chained_irq_enter(irq_chip, desc); >> + ret = regmap_read(chip->regmap, >> + PM8821_SSBI_REG_ADDR_IRQ_MASTER0, &master); >> + if (ret) { >> + pr_err("Failed to re:Qad master 0 ret=%d\n", ret); > > Hm? vi? yes.. That was good catch!! will fix it in next version... >