Date: Mon, 14 Nov 2016 21:51:53 +0100
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Karatas Ozgur <mueddib@openldap.org>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: FireWire/ nosy compile error (was gregkh@linuxfoundation.org 
 linux-kernel@vger.kernel.org)
Message-ID: <20161114215153.7027662c@kant>
In-Reply-To: <222561479135211@web23m.yandex.ru>
References: <222561479135211@web23m.yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 30

On Nov 14 Karatas Ozgur wrote:
> Hi,
> 
> I fixed compile error, not include to FIREWIRE variable and only PCI return an error.
> 
> 
> diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
> 
> index 145974f..60e5a8c 100644
> --- a/drivers/firewire/Kconfig
> +++ b/drivers/firewire/Kconfig
> @@ -57,7 +57,7 @@ config FIREWIRE_NET
> 
> config FIREWIRE_NOSY
>         tristate "Nosy - a FireWire traffic sniffer for PCILynx cards"
> -       depends on PCI
> +       depends on FIREWIRE && PCI
>         help
>           Nosy is an IEEE 1394 packet sniffer that is used for protocol
>           analysis and in development of IEEE 1394 drivers, applications,

This is wrong.  The variable FIREWIRE enables the firewire-core driver.
But nosy is a stand-alone driver which does not depend on firewire-core.

Please tell us what your compile error was (and on what platform), so that
we can find out which dependency was really missing, if any.
-- 
Stefan Richter
-======----- =-== -===-
http://arcgraph.de/sr/