From: ebiederm@xmission.com (Eric W. Biederman)
To: Peter Zijlstra <peterz@infradead.org>
Cc: Hari Bathini <hbathini@linux.vnet.ibm.com>, ast@fb.com,
        lkml <linux-kernel@vger.kernel.org>, acme@kernel.org,
        alexander.shishkin@linux.intel.com, mingo@redhat.com,
        daniel@iogearbox.net, rostedt@goodmis.org,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        sargun@sargun.me, Aravinda Prasad <aravinda@linux.vnet.ibm.com>,
        brendan.d.gregg@gmail.com
References: <147877784354.29988.8570048236764105701.stgit@hbathini.in.ibm.com>
        <147877788475.29988.17221764769834489874.stgit@hbathini.in.ibm.com>
        <20161110131905.GU3117@twins.programming.kicks-ass.net>
        <334ecc4f-aacf-4cbe-8858-7ec674f98b24@linux.vnet.ibm.com>
        <20161114104612.GA3102@twins.programming.kicks-ass.net>
Date: Mon, 14 Nov 2016 14:57:17 -0600
In-Reply-To: <20161114104612.GA3102@twins.programming.kicks-ass.net> (Peter
        Zijlstra's message of "Mon, 14 Nov 2016 11:46:12 +0100")
Message-ID: <87inrpkceq.fsf@xmission.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1630
Lines: 51

Peter Zijlstra <peterz@infradead.org> writes:

> On Mon, Nov 14, 2016 at 04:02:30PM +0530, Hari Bathini wrote:
>
>> >>  	PERF_RECORD_SWITCH_CPU_WIDE		= 15,
>> >>+	/*
>> >>+	 * struct {
>> >>+	 *	struct perf_event_header	header;
>> >>+	 *
>> >>+	 *	u32				pid, tid;
>> >>+	 *	u64				time;
>> >>+	 *	u32				uts_ns_inum;
>> >>+	 *	u32				ipc_ns_inum;
>> >>+	 *	u32				mnt_ns_inum;
>> >>+	 *	u32				pid_ns_inum;
>> >>+	 *	u32				net_ns_inum;
>> >>+	 *	u32				cgroup_ns_inum;
>> >>+	 *	u32				user_ns_inum;
>> >>+	 * 	struct sample_id		sample_id;
>> >>+	 * };
>> >>+	 */
>> >>+	PERF_RECORD_NAMESPACES			= 16,
>> >So this format is not extensible, that is, if someone adds yet another
>> >namespace, we'll need to introduce PERF_RECORD_NAMESPACES2.
>> >
>> >Is there a 'natural' and exposed namespace index that we can use to
>> >change it like:
>> >
>> >	u32	nr_nss;
>> >	u32	namespace[nr_nss];
>> >
>> >?
>> 
>> Nothing of that sort exists, currently.
>> Maybe, time to introduce with this patch-set..?
>
> Would be good, but you'll have to sort that with the namespace folks.

The somewhat easy answer is to use the unshare flags.  AKA CLONE_NEWNS,
CLONE_NEWUSER, ...

In the worst case things may get extended to the point where perf would
have to use a different set of values than we use to unshare, clone, and
setns (as the clone flags are effectively all used up) but for the
existing namespaces that index should work just fine.

That won't allow for a natural array in the record but it will allow for
an array with that has a tag for which namespace it is in, or
alternative it will allow for one record per namespace.

Eric