Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941041AbcKNWJe (ORCPT ); Mon, 14 Nov 2016 17:09:34 -0500 Received: from mail-bl2nam02on0040.outbound.protection.outlook.com ([104.47.38.40]:31680 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S938974AbcKNWJb (ORCPT ); Mon, 14 Nov 2016 17:09:31 -0500 X-Greylist: delayed 167802 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Nov 2016 17:09:30 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=alex.g@adaptrum.com; Subject: Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed To: Florian Fainelli , David Miller References: <1478993533-1936-1-git-send-email-alex.g@adaptrum.com> <20161114.161818.1460191406108019273.davem@davemloft.net> CC: , , From: Alex Message-ID: Date: Mon, 14 Nov 2016 13:54:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [198.0.218.81] X-ClientProxiedBy: BY2PR11CA0070.namprd11.prod.outlook.com (10.163.150.166) To BN3PR0401MB1169.namprd04.prod.outlook.com (10.160.155.147) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;2:qyYFKZMP8Ecu0PgwM86wR0BMbnJRQ9JdrswcI5wLHqwks0jmM3WqAG2zxwBbZXwD0XtrtMM5YUrdqCQmuq9fn67mwPjGouCCVJQT8TgwyWHF0BO3jyGPUN5kjnl4LobCPCtafbn+/CoBPR72+7O/WVezojWXc48bQ1ZnZGju4UI=;3:9JVwqWhQEVRqL0Fc9/nrakiw2D2SF414A42uLVoJ4VxL7p0dqgZ40MwoK9Za4cv5UHTnS0PBQWxzCcnl/QKXjwaldwggZACG0OTkO5Pa9i20OUFpTH33HHwvNbSlNGox816akO6K+faKsQmOr00XTKkvjmGwwMMUZwFxj+dHTSI= X-MS-Office365-Filtering-Correlation-Id: c94fd7a4-959f-411a-c98b-08d40cd8e5f2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN3PR0401MB1169; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;25:Jz0DkqXQp0cFbTQwhDfO6aLQZB7vt4tzvkNG8J+jkRWHBT+uRWHOm+88D00AKZSCfvJ13cOMQPOqYia9LrwygQCKEcbWwhzkmCeFB31cmS4/zvgyLvoceZsgkvijMBlEsSfklHN2O1SSUiisuShpFn/RB5/HWrbaW/y4d95nLwwfKngOtlIulJX3Y6Q1axX9kHP0lGMBycX24FSdPM7AtsqdE1DlqvYtQ8owwV2ciQ/mGXWdjAbMDpwxvg/oxd4oM2TM55V7UVznEjhhe6EvsRrrlRzwIVZ9NsMHxLqBHL+HIeOzzxaAyit0aacbb9oKeCXk6q7+cPd+Z6GWegOW3bTFyHpqK56V8+1n7hqj4GFk28An2G0cYXszGJhgGz9OMAStwTgUj4zO86jLZa31FzV3LEOGOYpeOVuqusuaw8qZ7k8wmxhReYdr0FxuV3t4Pw0H7u7y7r/pF5yoMt3QnhS59bPHHnI0wXyHF62VtiUPBlmgzd9ZsW2XWgtb+aQrz4FDm45MWshzE9oTi8K2/ZNC4tX7iXbGSqNQp6HZQKhGMSPdUIa/hA/NbTYbHoCkKWoScajLTAJy9kH2y4YZkhNXS63dabTz/p54IPYKU6alsl9AGor0Yhy7c0s26dzLypyLZitMJieqdCuZDC5qseNAhYXkKiEwb5IqzC5+3PoIk7kNkRl/NFReYS45le4ABRtZjDg0xfkT1Hr1XMZBQmTsq2OECm8DdX4t4znDh7o= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;31:EkMczqqKwZHYJ5/QnI0QMTYgTW+lIz/EQTVcWLaui3jddRCFlnb7mQmBQc7e9rUUzgu6MarBzH5VthN2zOf7GrlilEAMAEYJWR8YHaVOwfe5sZVDBEGMbGi9JtYDbgGucgu8UOk4yT5dy17sV09bN00QYqnh+SBIneWWYaeAizPabSLshioEqEUBqGvSYGkhxwN3Z9kxKLr7B7FkxID6tSOGX/TqfjfsXX02IIYjYwnu6SjRDFv9Lnp6vjrGFVpa;4:pATgPktolMrh+n5tSkrr6U0RkJB1svfG7j+F1rHQYqO+ixa7I9rLJzbStDyzQw3eLa/Q7FadWbhONeWq93ENdIm0JtA5csVv4DFCqoNNje08r2R8WUV3ESa7isc/a84oXwQJp98SgAZiw9/hxkDUF00G7OLPgTVKKIRwNY4HaOjevnB4bIvmBbzS4uV70FMhv1fYt08w+8Nfh039n1WflBlkQcJbiiOtxOaNNJTHg31vWYJOPs2zpXH4/njn/3OUzfNa7mq2v5P8zUXf1QBzfqxLAtoeyrS9ERRCgWs5ojP7B5NL72Lb5ZMlS4+R6Lyj3aG9xTpX+CdxRZDSoZvaBY0l194LPCMsm3/DmHKzl9WkxVVJM9W651zchpWCB45JX+hyReNoiN5hOQPCJE8qoSEsa2Cx4T4Z7apAkCyTaZ5WzJaI+DQvMpPVrdocd68m X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6061324)(6043046);SRVR:BN3PR0401MB1169;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0401MB1169; X-Forefront-PRVS: 0126A32F74 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(377454003)(189002)(199003)(3846002)(81156014)(50466002)(101416001)(6116002)(2906002)(86362001)(68736007)(31696002)(65826007)(5660300001)(36756003)(76176999)(305945005)(5001770100001)(8676002)(54356999)(65806001)(50986999)(65956001)(66066001)(189998001)(47776003)(229853002)(4001350100001)(92566002)(106356001)(105586002)(2950100002)(42186005)(31686004)(4326007)(23676002)(77096005)(97736004)(230700001)(6666003)(64126003)(83506001)(33646002)(7846002)(81166006)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0401MB1169;H:nuke-mobile.adaptrum;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjA0MDFNQjExNjk7MjM6cTlQem0vcVNjK0ZiTE5QY1hLa0FJQ0FY?= =?utf-8?B?MWVybmdmWS9kNzhKUUM3VlpPOC9GM0J0ejh0MWZmVkZic1hGWG5VUDA0SFVB?= =?utf-8?B?S3FwY09jelQrN1VjcWpOR0tJb0VwTW5sbHB3SWMyL1hEUGdlS21zcTJNeFZS?= =?utf-8?B?cVZsLzNYVTI4Y0dia3lXZk50TVVoZHlqUUZGbEFENUk5dlBESjFZWG1VVXNJ?= =?utf-8?B?SW1ucXNlZit3L0h1RmRsNmljUXpnYjNPSnBIdFl0bEZqNXNCdUlZTlZES050?= =?utf-8?B?dVJiYVJkQWxBbVIremN4WGpQV0lFS3RjN05YNGdLUWlpRkRmYVBRMDBxVEY0?= =?utf-8?B?bXlSU2U4YjJDOG9xMWw4ZlNHWFBFNGhBOTVRdHI0VGdFMjNSREd2RGFRWWgw?= =?utf-8?B?c0pJVXhLTHNxNVp4enViWWpqR0FpRi9HTjJxSjlGS1lXalpHbW9SUGlHR2Fa?= =?utf-8?B?WFBCRlBUaEs4aUgzNXhZMmlhWU1Mazk1SFgxK2tyZWdqY1puTGNJRDdJMFFw?= =?utf-8?B?SHA2bVVObnl2SlBWZUhRVzZhS0tZVG4rU0RRWDlvM2N3UXpwc3g2Z0haS0xY?= =?utf-8?B?cXh4Vkc3VHdRSXJ5OUJxOUcrUHNlTHZrdTBaRkZjSUJmSnUyYmZzMHBoTjU5?= =?utf-8?B?elVzTUp5NnRhZS83NG1YSUpvQk5Sa0owUjcyZWFBNU9ZZ2FVUXhoRlBwdnp4?= =?utf-8?B?TzBOUURvUWQxRkw4Q08wQXpRTDZ4QjhQU1htVjNXOXEyTUMvaVJ5VjdUUmJF?= =?utf-8?B?a0lSTWppNWJNUG53eHNtcmcxMzZTUWxvcStZWkxOYm03aFluU0l0bTd5QkN2?= =?utf-8?B?ckFsdVkxZW9lWXkzOTh2bnVWYnF4MDlmdGJDbks1Vmw4QitvTkx3Uk1tSVF4?= =?utf-8?B?UWUwWG4wTG9KTE1HdWIvTWFFSXZlR1FUaCtwVDRsQlJjM01aaXV3aUwwRlpu?= =?utf-8?B?cUhBVERMak10RHpDUXlRVm4yeHFIcUFQTlg1dkdWZWJjdUxycktZS05Pa1Vs?= =?utf-8?B?WE8zQ3N0Znh5eFA0WnExdHhIVzZrWmRqdm1YOGtrWFpzYjAxMG81cC9VbU5C?= =?utf-8?B?SDREaWl0TnptZ2FpRVVMcS9mZjByNGdGMXFMeHg4b1M2MjZkUG9qemY2UFlM?= =?utf-8?B?KzlXdkF0bVl0SVBQTzVsOTJTNmQ0emkzSXcvcTVJZFcycnhHeVVqTW1NK1px?= =?utf-8?B?NXhRVlhHSXd3YXkwVWpZa2hLVkRSQ3paMkxKa1YwTHBRNG1RSmhLdTlyd1Vv?= =?utf-8?B?dWE5N0kxVU9hTVkxUzBIMDl5ZGU4N21HWDRqVTR5ckZpeDNsK1hpZmFOWkt2?= =?utf-8?B?WUNRUDZpS0FVdXFqQ3RsL3VyanlHQnF6SU5vMXRwUUFzSE9pL2lCV08zNkRv?= =?utf-8?B?MldKTHNmT04rRGg0UFdZTkdXVlFnRjNpRjJzV2RweGUwOTlOb0s1dy9SaFZz?= =?utf-8?B?QVZvMzRINUw2NDBjeW1CWm5ZbjU0UlBSamVCcW00eHdmVUhpaHpZeGZLMFFL?= =?utf-8?B?aGN4UmU2S2VKamlOSEV4V09SWTRkdVJ2b0pENk5oM0x3d0o1eW9OUWVIQWhK?= =?utf-8?B?VTdEOVppeDJod3lPSHJ1NG5EK3hqQVBxRlhwUUhLdkkzYmw5VUsreWJ2VHoz?= =?utf-8?B?bC9FUWRLWjZVMVMvNDlnUUh6M3JpNTZFTEQ5WVRmWkIxeW9XT29BTFhOd0E9?= =?utf-8?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;6:b0NZyshQSZN5v9/z1GqnqH60K+ab5jJcaRwI5Ik+z3AVzBiSpxYzXOfYFoAti/66Pbry/LT3y0WOPNw8vK5c9tY2v5oteVgbZAVhtcNd67p7ecHLTC7sP0hsCJW/fpw3jfia1VpudpunZyb0dV9TBCJ64x2CM9Y4I4HebRR9el7M1qiFittvYk535Fo7oRUpn/DYkSYfvUQ/V6c/mxbCjWfrMTulgxdSjG1GIDsgBtSlNZD9U16OEGGoBrDL6ccrTXnVbngvIGa5GrKw3RQKlKOwji2uONLAkdG4iTVxxzlbOkTfxjggv0qOLMmNzIIk/85j4xBJZJAWzNo3OEA1mpfNVCOzKHzDmzSp6E4YfbdiGWmCo3en41ZcJ0MFr5GG;5:TWru9vLPfO/4Br/dTvwBBNUcTeGLdB/7SV++3omAuhz5MDyFEl1dSza7kzDDQIhazgY8OOmoyy1rtfqkec25vYARinb9Z++KCqj1L6P+1ZSBE15m8fDp3q9Gcck3p/MO5a2+LuY5WR2RPJChsilBCw==;24:NYG7S0lPZIcjpqxvQTa5gfx+mOdD1l1sxKAsKK88ok4UpxL5mcOW1gFotC+eVOSRaKaLMcWEhhbSyd0lCqbbBR08kaMBeWqKVTUptDbWR80= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR0401MB1169;7:NjovoLyQN+yaEXjwfROaO9sYcjuSk4moWNGglh2WuLtinVVCugPaJLgZy/XLnTMxffNfGLyMTAUnsyf+PPaBIgkCV8mhMqdtZoz/WprBhfIk2bHhXbr1/dZCe5F/50pOFsibtZlnP590R+s9ORqrBL5RFWLjgcxbw+piQa7zRuQsDb+KPtyx3axs1A1jn1OdfWvDhKZEbvwpe/9fiqmb2CCbhOCubV8rsTLB8RS6CftcoHkEWcm57ZSzKXoSnOsO9k7OU5r25QnuYnuLQHEP8JjnZU7CvFWCLHeEtybp3kgMpocnr4hn0RiyIPoEwv3Loqam0r2m060fVFqQN0qa6R/KR4GSTCtzb0dhr/ZEhtM= X-OriginatorOrg: adaptrum.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2016 21:55:07.1051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0401MB1169 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 644 Lines: 24 On 11/14/2016 01:25 PM, Florian Fainelli wrote: > On 11/14/2016 01:18 PM, David Miller wrote: >> From: Alexandru Gagniuc >> Date: Sat, 12 Nov 2016 15:32:13 -0800 >> >>> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) >>> + ret = vsc8601_add_skew(phydev); >> >> I think you should use phy_interface_is_rgmii() here. >> > > This would include all RGMII modes, here I think the intent is to check > for PHY_INTERFACE_MODE_RGMII_ID and PHY_INTERFACE_MODE_RGMII_TXID (or > RXID), That is correct. > Alexandru, what direction does the skew settings apply to? It applies a skew in both TX and RX directions. Alex