Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941056AbcKNWVS (ORCPT ); Mon, 14 Nov 2016 17:21:18 -0500 Received: from mga09.intel.com ([134.134.136.24]:8536 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938761AbcKNWVQ (ORCPT ); Mon, 14 Nov 2016 17:21:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,640,1473145200"; d="scan'208";a="1059438114" Date: Mon, 14 Nov 2016 14:21:14 -0800 From: Jarkko Sakkinen To: Nayna Jain Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v6 2/9] tpm: replace symbolic permission with octal for securityfs files Message-ID: <20161114222114.wtk2nypib2o4zfvk@intel.com> References: <1479117656-12403-1-git-send-email-nayna@linux.vnet.ibm.com> <1479117656-12403-3-git-send-email-nayna@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479117656-12403-3-git-send-email-nayna@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 42 On Mon, Nov 14, 2016 at 05:00:49AM -0500, Nayna Jain wrote: > checkpatch.pl flags warning for symbolic permissions and suggests > to replace with octal value. > > This patch changes securityfs pseudo files permission > to octal values in tpm_bios_log_setup(). > > Signed-off-by: Nayna Jain Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_eventlog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c > index 42b49c4..9467e31 100644 > --- a/drivers/char/tpm/tpm_eventlog.c > +++ b/drivers/char/tpm/tpm_eventlog.c > @@ -378,7 +378,7 @@ struct dentry **tpm_bios_log_setup(const char *name) > > bin_file = > securityfs_create_file("binary_bios_measurements", > - S_IRUSR | S_IRGRP, tpm_dir, > + 0440, tpm_dir, > (void *)&tpm_binary_b_measurements_seqops, > &tpm_bios_measurements_ops); > if (is_bad(bin_file)) > @@ -386,7 +386,7 @@ struct dentry **tpm_bios_log_setup(const char *name) > > ascii_file = > securityfs_create_file("ascii_bios_measurements", > - S_IRUSR | S_IRGRP, tpm_dir, > + 0440, tpm_dir, > (void *)&tpm_ascii_b_measurements_seqops, > &tpm_bios_measurements_ops); > if (is_bad(ascii_file)) > -- > 2.5.0 >