Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755189AbcKNWxW (ORCPT ); Mon, 14 Nov 2016 17:53:22 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:35984 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbcKNWxV (ORCPT ); Mon, 14 Nov 2016 17:53:21 -0500 Subject: Re: [PATCH 2/2] usb: dwc2: fixes host_dma logic To: Christian Lamparter , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" References: <4043f817106c8dffdc9a3f411d965465168b263d.1478897792.git.chunkeey@gmail.com> From: John Youn CC: John Youn , Mark Rutland , Rob Herring , Greg Kroah-Hartman , Felipe Balbi Message-ID: Date: Mon, 14 Nov 2016 14:53:18 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4043f817106c8dffdc9a3f411d965465168b263d.1478897792.git.chunkeey@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.139.160] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 51 On 11/11/2016 12:59 PM, Christian Lamparter wrote: > This patch moves the the host_dma initialization > before dwc2_set_param_dma_desc_enable and > dwc2_set_param_dma_desc_fs_enable. The reason being > that both function need it. > > Fixes: 1205489cee75bf39 ("usb: dwc2: Get host DMA device properties") This should probably be omitted since it's only in Felipe's testing/next. Otherwise looks good. Acked-by: John Youn Regards, John > > Cc: John Youn > Cc: Felipe Balbi > Signed-off-by: Christian Lamparter > --- > drivers/usb/dwc2/params.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index 5d822c5..222a83c 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -1157,9 +1157,6 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg, > bool dma_capable = !(hw->arch == GHWCFG2_SLAVE_ONLY_ARCH); > > dwc2_set_param_otg_cap(hsotg, params->otg_cap); > - dwc2_set_param_dma_desc_enable(hsotg, params->dma_desc_enable); > - dwc2_set_param_dma_desc_fs_enable(hsotg, params->dma_desc_fs_enable); > - > if ((hsotg->dr_mode == USB_DR_MODE_HOST) || > (hsotg->dr_mode == USB_DR_MODE_OTG)) { > bool disable; > @@ -1174,6 +1171,8 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg, > !disable, false, > dma_capable); > } > + dwc2_set_param_dma_desc_enable(hsotg, params->dma_desc_enable); > + dwc2_set_param_dma_desc_fs_enable(hsotg, params->dma_desc_fs_enable); > > dwc2_set_param_host_support_fs_ls_low_power(hsotg, > params->host_support_fs_ls_low_power); >