Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965449AbcKNXjw (ORCPT ); Mon, 14 Nov 2016 18:39:52 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:42998 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965251AbcKNXjs (ORCPT ); Mon, 14 Nov 2016 18:39:48 -0500 To: Mauricio Faria de Oliveira Cc: Himanshu.Madhani@cavium.com, qla2xxx-upstream@qlogic.com, martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qla2xxx: do not abort all commands in the adapter during EEH recovery From: "Martin K. Petersen" Organization: Oracle Corporation References: <1479158782-4544-1-git-send-email-mauricfo@linux.vnet.ibm.com> Date: Mon, 14 Nov 2016 18:39:37 -0500 In-Reply-To: <1479158782-4544-1-git-send-email-mauricfo@linux.vnet.ibm.com> (Mauricio Faria de Oliveira's message of "Mon, 14 Nov 2016 19:26:22 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 15 >>>>> "Mauricio" == Mauricio Faria de Oliveira writes: Mauricio> The previous commit ("qla2xxx: fix invalid DMA access after Mauricio> command aborts in PCI device remove") introduced a regression Mauricio> during an EEH recovery, since the change to the Mauricio> qla2x00_abort_all_cmds() function calls qla2xxx_eh_abort(), Mauricio> which verifies the EEH recovery condition but handles it Mauricio> heavy-handed. (commit a465537ad1a4 "qla2xxx: Disable the Mauricio> adapter and skip error recovery in case of register Mauricio> disconnect.") Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering