Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941086AbcKOAOp (ORCPT ); Mon, 14 Nov 2016 19:14:45 -0500 Received: from mga05.intel.com ([192.55.52.43]:26696 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755212AbcKOAOn (ORCPT ); Mon, 14 Nov 2016 19:14:43 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,640,1473145200"; d="scan'208";a="31265130" Date: Mon, 14 Nov 2016 16:14:42 -0800 From: Jarkko Sakkinen To: Nayna Jain Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v6 7/9] tpm: redefine read_log() to handle ACPI/OF at runtime Message-ID: <20161115001442.ldavk5vsrbukzyhq@intel.com> References: <1479117656-12403-1-git-send-email-nayna@linux.vnet.ibm.com> <1479117656-12403-8-git-send-email-nayna@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479117656-12403-8-git-send-email-nayna@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 18 On Mon, Nov 14, 2016 at 05:00:54AM -0500, Nayna Jain wrote: > Currently, read_log() has two implementations: one for ACPI platforms > and the other for device tree(OF) based platforms. The proper one is > selected at compile time using Kconfig and #ifdef in the Makefile, > which is not the recommended approach. > > This patch removes the #ifdef in the Makefile by defining a single > read_log() method, which checks for ACPI/OF event log properties at > runtime. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Nayna Jain > Reviewed-by: Jason Gunthorpe > Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen /Jarkko