Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965529AbcKOByt (ORCPT ); Mon, 14 Nov 2016 20:54:49 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:33399 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933258AbcKOByr (ORCPT ); Mon, 14 Nov 2016 20:54:47 -0500 Date: Mon, 14 Nov 2016 19:54:42 -0600 From: Rob Herring To: Mugunthan V N Cc: linux-input@vger.kernel.org, Dmitry Torokhov , Jonathan Cameron , Mark Rutland , Lee Jones , Sekhar Nori , Vignesh R , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] dt/binding: ti-tsc-adc: deprecate ti,charge-delay and add binding doc for ti,charge-delay-ns Message-ID: <20161115015442.pexycr4adco3hnug@rob-hp-laptop> References: <20161110163515.27598-1-mugunthanvnm@ti.com> <20161110163515.27598-2-mugunthanvnm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161110163515.27598-2-mugunthanvnm@ti.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 17 On Thu, Nov 10, 2016 at 10:05:13PM +0530, Mugunthan V N wrote: > ti,charge-delay represents the duration that ADC should wait > before sampling the ADC line to detect the touch location and pen > up/downs. Currently the ADC clock is set at 3MHz. The device-tree > entry for ti,charge-delay is based on assumption of ADC clock at > 3MHz, but it can be operated up to 24MHz clock. Representing the > charge delay of touchscreen in terms of ADC clocks is incorrect. > So change this representation to ti,charge-delay-ns, which driver > can convert it to number clock cycles based on ref clock > frequency. > > Signed-off-by: Mugunthan V N > --- > .../bindings/input/touchscreen/ti-tsc-adc.txt | 32 ++++++++++++++-------- > 1 file changed, 21 insertions(+), 11 deletions(-) Acked-by: Rob Herring