Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965206AbcKOCcT (ORCPT ); Mon, 14 Nov 2016 21:32:19 -0500 Received: from conssluserg-03.nifty.com ([210.131.2.82]:53601 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753369AbcKOCcR (ORCPT ); Mon, 14 Nov 2016 21:32:17 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com uAF2WEZ8009396 X-Nifty-SrcIP: [209.85.161.174] MIME-Version: 1.0 In-Reply-To: <5a1b5ef5-5c1a-ce20-f0be-ed6abed6996e@gmail.com> References: <1478666130-13413-1-git-send-email-yamada.masahiro@socionext.com> <1478666130-13413-6-git-send-email-yamada.masahiro@socionext.com> <5a1b5ef5-5c1a-ce20-f0be-ed6abed6996e@gmail.com> From: Masahiro Yamada Date: Tue, 15 Nov 2016 11:32:13 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/11] mtd: nand: denali: remove "Spectra:" prefix from printk strings To: Marek Vasut Cc: linux-mtd@lists.infradead.org, Alan Cox , David Woodhouse , Jason Roberts , Chuanxiao Dong , Dinh Nguyen , Linux Kernel Mailing List , Boris Brezillon , Brian Norris , Richard Weinberger , David Woodhouse , Cyrille Pitchen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 35 2016-11-13 6:35 GMT+09:00 Marek Vasut : > On 11/09/2016 05:35 AM, Masahiro Yamada wrote: >> As far as I understood from the Kconfig menu deleted by commit >> be7f39c5ecf5 ("Staging: delete spectra driver"), the "Spectra" is >> specific to Intel Moorestown Platform. >> >> The Denali NAND controller IP is used for various SoCs such as >> Altera SOCFPGA, Socionext UniPhier, etc. The platform specific >> strings are not preferred in this driver. >> >> Signed-off-by: Masahiro Yamada > > Reviewed-by: Marek Vasut > >> --- >> >> As an ARM-SoC developer, I only need denali.c and denali_dt.c. >> >> I see some "Spectra:" in drivers/mtd/nand/denali_pci.c as well. >> I was not quite sure if they are needed or not. >> If desired, I can update this patch to remove them too. > > Is anyone even using Denali on Intel now ? I assume this question is address to Intel guys, not me. May I drop the "Spectra:" from printk strings entirely? -- Best Regards Masahiro Yamada