Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965561AbcKODWn (ORCPT ); Mon, 14 Nov 2016 22:22:43 -0500 Received: from regular1.263xmail.com ([211.150.99.134]:37593 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941179AbcKODWl (ORCPT ); Mon, 14 Nov 2016 22:22:41 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: wulf@rock-chips.com X-FST-TO: groeck@google.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wulf@rock-chips.com X-UNIQUE-TAG: <3a890761b2b5cfc1873ffc723601c0eb> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback To: Doug Anderson References: <1479106911-16049-1-git-send-email-wulf@rock-chips.com> <1479106911-16049-2-git-send-email-wulf@rock-chips.com> Cc: Kishon Vijay Abraham I , =?UTF-8?Q?Heiko_St=c3=bcbner?= , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , Rob Herring , Frank Wang , =?UTF-8?B?6buE5rab?= , Brian Norris , Guenter Roeck From: wlf Message-ID: Date: Tue, 15 Nov 2016 11:22:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 26 Hi Doug, 在 2016年11月15日 02:15, Doug Anderson 写道: > William > > On Sun, Nov 13, 2016 at 11:01 PM, William Wu wrote: >> Since we needs to delay ~1ms to wait for 480MHz output clock >> of USB2 PHY to become stable after turn on it, the delay time >> is pretty long for something that's supposed to be "atomic" >> like a clk_enable(). Consider that clk_enable() will disable >> interrupt and that a 1ms interrupt latency is not sensible. >> >> The 480MHz output clock should be handled in prepare callbacks >> which support gate a clk if the operation may sleep. >> >> Signed-off-by: William Wu >> --- >> drivers/phy/phy-rockchip-inno-usb2.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Douglas Anderson Thanks! I'll add Reviewed-by. > > >