Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755316AbcKOFKf (ORCPT ); Tue, 15 Nov 2016 00:10:35 -0500 Received: from host.buserror.net ([209.198.135.123]:35135 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbcKOFKe (ORCPT ); Tue, 15 Nov 2016 00:10:34 -0500 Message-ID: <1479186624.21746.15.camel@buserror.net> From: Scott Wood To: Paul Gortmaker , linux-kernel@vger.kernel.org Cc: Yangbo Lu , Arnd Bergmann , Ulf Hansson , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Date: Mon, 14 Nov 2016 23:10:24 -0600 In-Reply-To: <20161113190302.18099-4-paul.gortmaker@windriver.com> References: <20161113190302.18099-1-paul.gortmaker@windriver.com> <20161113190302.18099-4-paul.gortmaker@windriver.com> Organization: NXP Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 50.171.225.118 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [PATCH 3/3] soc: fsl: make guts driver explicitly non-modular X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 31 On Sun, 2016-11-13 at 14:03 -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/soc/fsl/Kconfig:config FSL_GUTS > drivers/soc/fsl/Kconfig:        bool > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since the code was already not using module_init, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Scott Wood > Cc: Yangbo Lu > Cc: Arnd Bergmann > Cc: Ulf Hansson > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker Acked-by: Scott Wood -Scott