Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941306AbcKOIaY (ORCPT ); Tue, 15 Nov 2016 03:30:24 -0500 Received: from web01.01d.eu ([5.200.27.195]:59702 "EHLO web01.01d.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752242AbcKOIaW (ORCPT ); Tue, 15 Nov 2016 03:30:22 -0500 From: Shiva Kerdel To: stuart.yoder@nxp.com Cc: gregkh@linuxfoundation.org, German.Rivera@freescale.com, treding@nvidia.com, itai.katz@nxp.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Shiva Kerdel Subject: [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16' Date: Tue, 15 Nov 2016 09:30:03 +0100 Message-Id: <20161115083003.6017-1-shiva@exdev.nl> X-Mailer: git-send-email 2.10.2 X-Authenticated-Id: shiva@exdev.nl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 29 After following a discussion about the used integer types Dan Carpenter pointed out that 'int' types should be used over the current change to 's16'. The reason for this is to have an upper bound instead of overflowing the 's16' so we could still remove devices. Signed-off-by: Shiva Kerdel Suggested-by: Stuart Yoder Suggested-by: Dan Carpenter --- drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h index c7cad87..42700de 100644 --- a/drivers/staging/fsl-mc/include/mc-bus.h +++ b/drivers/staging/fsl-mc/include/mc-bus.h @@ -42,8 +42,8 @@ struct msi_domain_info; */ struct fsl_mc_resource_pool { enum fsl_mc_pool_type type; - s16 max_count; - s16 free_count; + int max_count; + int free_count; struct mutex mutex; /* serializes access to free_list */ struct list_head free_list; struct fsl_mc_bus *mc_bus; -- 2.10.2