Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966617AbcKOKCL (ORCPT ); Tue, 15 Nov 2016 05:02:11 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39782 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941292AbcKOKCH (ORCPT ); Tue, 15 Nov 2016 05:02:07 -0500 Date: Tue, 15 Nov 2016 11:02:17 +0100 From: Greg KH To: Shiva Kerdel Cc: stuart.yoder@nxp.com, German.Rivera@freescale.com, treding@nvidia.com, itai.katz@nxp.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16' Message-ID: <20161115100217.GA19614@kroah.com> References: <20161115083003.6017-1-shiva@exdev.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161115083003.6017-1-shiva@exdev.nl> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 19 On Tue, Nov 15, 2016 at 09:30:03AM +0100, Shiva Kerdel wrote: > After following a discussion about the used integer types Dan Carpenter > pointed out that 'int' types should be used over the current change to > 's16'. The reason for this is to have an upper bound instead of overflowing > the 's16' so we could still remove devices. > > Signed-off-by: Shiva Kerdel > Suggested-by: Stuart Yoder > Suggested-by: Dan Carpenter > --- > drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) In the future, don't do [RESPIN] as that means nothing to me, and is just noise... thanks, greg k-h