Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934836AbcKOKqj (ORCPT ); Tue, 15 Nov 2016 05:46:39 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:58956 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934486AbcKOKqd (ORCPT ); Tue, 15 Nov 2016 05:46:33 -0500 Subject: Re: [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node To: Alexandre Bailon , , , References: <1478188752-22447-1-git-send-email-abailon@baylibre.com> <1478188752-22447-5-git-send-email-abailon@baylibre.com> CC: , , , From: Sekhar Nori Message-ID: <0c94c5e0-9d2c-fff5-1213-2fb2adb20ab0@ti.com> Date: Tue, 15 Nov 2016 16:16:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478188752-22447-5-git-send-email-abailon@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 65 On Thursday 03 November 2016 09:29 PM, Alexandre Bailon wrote: > This adds the device tree node for the usb otg > controller present in the da850 family of SoC's. > This also enables the otg usb controller for the lcdk board. > > Signed-off-by: Alexandre Bailon > --- > arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ > arch/arm/boot/dts/da850.dtsi | 15 +++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index 7b8ab21..9f5040c 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -158,6 +158,14 @@ > rx-num-evt = <32>; > }; > > +&usb_phy { > + status = "okay"; > + }; As mentioned by David already, this node needs to be removed. Please rebase this on top of latest linux-davinci/master when ready for merging (driver changes accepted). > + > +&usb0 { > + status = "okay"; > +}; > + > &aemif { > pinctrl-names = "default"; > pinctrl-0 = <&nand_pins>; > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index f79e1b9..322a31a 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -372,6 +372,21 @@ > >; > status = "disabled"; > }; > + usb_phy: usb-phy { > + compatible = "ti,da830-usb-phy"; > + #phy-cells = <1>; > + status = "disabled"; > + }; > + usb0: usb@200000 { > + compatible = "ti,da830-musb"; > + reg = <0x200000 0x10000>; > + interrupts = <58>; > + interrupt-names = "mc"; > + dr_mode = "otg"; > + phys = <&usb_phy 0>; > + phy-names = "usb-phy"; > + status = "disabled"; > + }; Can you separate out the soc specific changes from board changes? Please place the usb0 node above the mdio node. I am trying to get to a rough ordering based on reg property. Thanks, Sekhar