Subject: Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible
 entries
To: Jan Beulich <JBeulich@suse.com>
References: <1479168677-23633-1-git-send-email-athorlton@sgi.com>
 <a03b2e71-cc6a-7f62-6c09-877c576fab80@suse.com>
 <582AC427020000780011EA7E@suse.com>
 <a02052dd-83f8-2e6f-2dd3-e7165708225d@suse.com>
 <582ACEDE020000780011EAC9@suse.com>
 <478e5d05-ccf6-093e-8301-0eece00ca243@suse.com>
 <582AE72D020000780011EBB2@suse.com>
 <4bac3691-f157-4acc-7b29-7c49be6d35d6@suse.com>
 <582AF51F020000780011ECB4@suse.com>
Cc: David Vrabel <david.vrabel@citrix.com>, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, xen-devel@lists.xenproject.org,
        Ingo Molnar <mingo@redhat.com>, Alex Thorlton <athorlton@sgi.com>,
        Russ Anderson <rja@sgi.com>, linux-kernel@vger.kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <dcaf32d2-9d26-b966-bf94-1ea3e888403c@suse.com>
Date: Tue, 15 Nov 2016 12:07:42 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <582AF51F020000780011ECB4@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1874
Lines: 43

On 15/11/16 11:44, Jan Beulich wrote:
>>>> On 15.11.16 at 10:55, <JGross@suse.com> wrote:
>> On 15/11/16 10:45, Jan Beulich wrote:
>>>>>> On 15.11.16 at 09:42, <JGross@suse.com> wrote:
>>>> For a fully dynamical solution we'd need a way to get a partial
>>>> E820 map from the hypervisor (e.g. first 128 entries) in order to
>>>> be able to setup at least some memory and later get the rest of
>>>> the memory map using some dynamically allocated memory.
>>>
>>> And we could of course also make the hypercall allow for that (e.g.
>>> by defining the semantics of a specific error code, so far not used
>>> by it, to avoid mis-interpretation of output on older hypervisors),
>>> or introduce a new clone of the existing one(s).
>>
>> I'd go with the new error code. What about E2BIG or ENOSPC?
> 
> Either seems fine.
> 
>> I think the hypervisor should fill in the number of entries required
>> in this case.
> 
> And you'd then mean the caller to imply that the passed in (and now
> overwritten) count to describe how many entries got filled? That's
> not that nice an interface. I'd rather return the number of entries
> filled, and require the sizing variant (NULL handle) to be used to
> obtain the number of entries. After all if a caller _wants_ to handle
> a partial map, it doesn't really care how many further entries there
> are.

I just wanted to avoid two interface changes. IMO the caller knows the
buffer size he supplied and it is rather clear that e.g. E2BIG means
it has been filled completely.

And the assumption the caller doesn't care for the further entries is
not necessarily true: he might not care at the moment of the call, but
he will eventually care for them later when he is able to allocate an
appropriate sized buffer.

OTOH I'm not feeling strong in this case and you are the hypervisor
maintainer. Either solution is fine for me.


Juergen