Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbcKOLmA (ORCPT ); Tue, 15 Nov 2016 06:42:00 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37689 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbcKOLl4 (ORCPT ); Tue, 15 Nov 2016 06:41:56 -0500 Date: Tue, 15 Nov 2016 12:41:51 +0100 From: Christoffer Dall To: "Longpeng(Mike)" Cc: marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zhaoshenglong@huawei.com, wu.wubin@huawei.com Subject: Re: [PATCH] arm/arm64: KVM: clean up useless code in kvm_timer_enable Message-ID: <20161115114151.GA3811@cbox> References: <1478659814-364872-1-git-send-email-longpeng2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478659814-364872-1-git-send-email-longpeng2@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 46 On Wed, Nov 09, 2016 at 10:50:14AM +0800, Longpeng(Mike) wrote: > 1) Since commit:41a54482 changed timer enabled variable to per-vcpu, > the correlative comment in kvm_timer_enable is useless now. > > 2) After the kvm module init successfully, the timecounter is always > non-null, so we can remove the checking of timercounter. > > Signed-off-by: Longpeng(Mike) Acked-by: Christoffer Dall > --- > virt/kvm/arm/arch_timer.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c > index 27a1f63..17b8fa5 100644 > --- a/virt/kvm/arm/arch_timer.c > +++ b/virt/kvm/arm/arch_timer.c > @@ -498,17 +498,7 @@ int kvm_timer_enable(struct kvm_vcpu *vcpu) > if (ret) > return ret; > > - > - /* > - * There is a potential race here between VCPUs starting for the first > - * time, which may be enabling the timer multiple times. That doesn't > - * hurt though, because we're just setting a variable to the same > - * variable that it already was. The important thing is that all > - * VCPUs have the enabled variable set, before entering the guest, if > - * the arch timers are enabled. > - */ > - if (timecounter) > - timer->enabled = 1; > + timer->enabled = 1; > > return 0; > } > -- > 1.8.3.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html