Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbcKOL7T (ORCPT ); Tue, 15 Nov 2016 06:59:19 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:4853 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbcKOL7S (ORCPT ); Tue, 15 Nov 2016 06:59:18 -0500 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 15 Nov 2016 03:59:16 -0800 Message-ID: <582AF4B7.4050705@nvidia.com> Date: Tue, 15 Nov 2016 17:12:47 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Rob Herring CC: , , , , "Douglas Anderson" , Aleksandr Frid Subject: Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential voltage transition References: <1478281075-3498-1-git-send-email-ldewangan@nvidia.com> <20161114154807.j4oo4veslhknauxy@rob-hp-laptop> In-Reply-To: <20161114154807.j4oo4veslhknauxy@rob-hp-laptop> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRBGMAIL101.nvidia.com (10.18.16.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1973 Lines: 46 On Monday 14 November 2016 09:18 PM, Rob Herring wrote: > On Fri, Nov 04, 2016 at 11:07:54PM +0530, Laxman Dewangan wrote: >> Some PWM regulator has the exponential transition in voltage change as >> opposite to fixed slew-rate linear transition on other regulators. >> For such PWM regulators, add the property for providing the delay >> from DT node. >> >> Add DT binding details of the new property >> "pwm-regulator-voltage-ramp-time-us" added for providing voltage >> transition delay. >> >> Signed-off-by: Laxman Dewangan >> CC: Douglas Anderson >> CC: Aleksandr Frid >> >> --- >> This patch is continuation of discussion on patch >> regulator: pwm: Fix regulator ramp delay for continuous mode >> https://patchwork.kernel.org/patch/9216857/ >> where is it discussed to have separate property for PWM which has >> exponential voltage transition. >> --- >> Documentation/devicetree/bindings/regulator/pwm-regulator.txt | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt >> index 3aeba9f..a163f42 100644 >> --- a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt >> +++ b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt >> @@ -54,6 +54,16 @@ Optional properties: >> -------------------- >> - enable-gpios: GPIO to use to enable/disable the regulator >> >> +- pwm-regulator-voltage-ramp-time-us: Integer, voltage ramp time in > This is a really long name. Drop the 'pwm-regulator-' part as it is > redundant. The fact that it is PWM reg specific is captured as it is > documented that way. > We already have the regulator-ramp-delay from the regulator core. Just wanted to make this (pwm-regulator-voltage-ramp-time-us) for pwm specific. Can we have "pwm-regulator-ramp-delay" or "pwm-regulator-settling-time-us"?