Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753576AbcKOMWQ (ORCPT ); Tue, 15 Nov 2016 07:22:16 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:19181 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbcKOMWN (ORCPT ); Tue, 15 Nov 2016 07:22:13 -0500 Date: Tue, 15 Nov 2016 15:21:54 +0300 From: Dan Carpenter To: Sergio Paracuellos Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: wlan-ng: use GENMASK macro in different defines of hfa384x.h Message-ID: <20161115122153.GO28701@mwanda> References: <1478801802-7731-1-git-send-email-sergio.paracuellos@gmail.com> <1478801802-7731-2-git-send-email-sergio.paracuellos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478801802-7731-2-git-send-email-sergio.paracuellos@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 273 Lines: 8 On Thu, Nov 10, 2016 at 07:16:39PM +0100, Sergio Paracuellos wrote: > +#define HFA384x_CMD_AINFO ((u16)GENMASK(14, 8)) The casts to u16 are pointless because of type promotion and half of these defines aren't used anyway (both that I looked at). regards, dan carpenter