Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933229AbcKOMaZ (ORCPT ); Tue, 15 Nov 2016 07:30:25 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:36453 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657AbcKOMaX (ORCPT ); Tue, 15 Nov 2016 07:30:23 -0500 Date: Tue, 15 Nov 2016 15:25:17 +0300 From: Dan Carpenter To: Sergio Paracuellos Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] staging: wlan-ng: use GENMASK macro in different defines of p80211hdr.h Message-ID: <20161115122433.GP28701@mwanda> References: <1478801802-7731-1-git-send-email-sergio.paracuellos@gmail.com> <1478801802-7731-3-git-send-email-sergio.paracuellos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478801802-7731-3-git-send-email-sergio.paracuellos@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 435 Lines: 11 On Thu, Nov 10, 2016 at 07:16:40PM +0100, Sergio Paracuellos wrote: > -#define WLAN_GET_FC_FTYPE(n) ((((u16)(n)) & (BIT(2) | BIT(3))) >> 2) > -#define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & \ > - (BIT(4) | BIT(5) | BIT(6) | BIT(7))) >> 4) > +#define WLAN_GET_FC_FTYPE(n) ((((u16)(n)) & GENMASK(3, 2)) >> 2) > +#define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & GENMASK(7, 4)) >> 4) The casts to u16 are not needed. regards, dan carpenter