Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933699AbcKON12 (ORCPT ); Tue, 15 Nov 2016 08:27:28 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:30429 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbcKON1Y (ORCPT ); Tue, 15 Nov 2016 08:27:24 -0500 Date: Tue, 15 Nov 2016 16:26:27 +0300 From: Dan Carpenter To: Rahul Krishnan Cc: rmfrfs@gmail.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, johan@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block Message-ID: <20161115132627.GR28701@mwanda> References: <20161115132433.GA4534@rahul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161115132433.GA4534@rahul> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 27 On Tue, Nov 15, 2016 at 06:54:33PM +0530, Rahul Krishnan wrote: > This patch fixes the following checkpath.pl warning > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Rahul Krishnan > --- > drivers/staging/greybus/sdio.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c > index 5649ef1..f60b458 100644 > --- a/drivers/staging/greybus/sdio.c > +++ b/drivers/staging/greybus/sdio.c > @@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event) > state_changed = 1; > } > > - if (event & GB_SDIO_WP) { > - host->read_only = true; > - } > + if (event & GB_SDIO_WP) > + host->read_only = true; The indenting is messed up. regards, dan carpenter