Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261369AbTEHMJC (ORCPT ); Thu, 8 May 2003 08:09:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261374AbTEHMJC (ORCPT ); Thu, 8 May 2003 08:09:02 -0400 Received: from locutus.cmf.nrl.navy.mil ([134.207.10.66]:38802 "EHLO locutus.cmf.nrl.navy.mil") by vger.kernel.org with ESMTP id S261369AbTEHMI7 (ORCPT ); Thu, 8 May 2003 08:08:59 -0400 Message-Id: <200305081220.h48CK9Gi002815@locutus.cmf.nrl.navy.mil> To: Francois Romieu cc: davem@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one() In-reply-to: Your message of "Thu, 08 May 2003 01:01:46 +0200." <20030508010146.A20715@electric-eye.fr.zoreil.com> X-url: http://www.nrl.navy.mil/CCS/people/chas/index.html X-mailer: nmh 1.0 Date: Thu, 08 May 2003 08:20:09 -0400 From: chas williams Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 10 In message <20030508010146.A20715@electric-eye.fr.zoreil.com>,Francois Romieu writes: >- pci_enable_device() isn't balanced on error path; actually pci_disable_device() should probably go into he_stop() or add it to he_remove_one() and he_cleanup() - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/