Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935507AbcKOPWN (ORCPT ); Tue, 15 Nov 2016 10:22:13 -0500 Received: from relay1.sgi.com ([192.48.180.66]:58146 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbcKOPWM (ORCPT ); Tue, 15 Nov 2016 10:22:12 -0500 Date: Tue, 15 Nov 2016 09:22:09 -0600 From: Alex Thorlton To: Juergen Gross Cc: Jan Beulich , David Vrabel , x86@kernel.org, Thomas Gleixner , xen-devel@lists.xenproject.org, Ingo Molnar , Alex Thorlton , Russ Anderson , linux-kernel@vger.kernel.org, "H. Peter Anvin" Subject: Re: [RFC PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Message-ID: <20161115152209.GA67776@stormcage.americas.sgi.com> References: <1479168677-23633-1-git-send-email-athorlton@sgi.com> <582AC427020000780011EA7E@suse.com> <582ACEDE020000780011EAC9@suse.com> <478e5d05-ccf6-093e-8301-0eece00ca243@suse.com> <582AE72D020000780011EBB2@suse.com> <4bac3691-f157-4acc-7b29-7c49be6d35d6@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bac3691-f157-4acc-7b29-7c49be6d35d6@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 18 On Tue, Nov 15, 2016 at 10:55:49AM +0100, Juergen Gross wrote: > I'd go with the new error code. What about E2BIG or ENOSPC? > > I think the hypervisor should fill in the number of entries required > in this case. > > In case nobody objects I can post patches for this purpose (both Xen > and Linux). This sounds like a good solution to me. I think it's definitely more appropriate than simply bumping up the size of xen_e820_map, especially considering the fact that it's theoretically possible for the e820 map generated by the hypercall to grow too large, even on a non-EFI machine, where my change would have no effect. Thanks for your input! - Alex