Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941161AbcKOPhR (ORCPT ); Tue, 15 Nov 2016 10:37:17 -0500 Received: from mail-qt0-f182.google.com ([209.85.216.182]:33335 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941131AbcKOPhM (ORCPT ); Tue, 15 Nov 2016 10:37:12 -0500 MIME-Version: 1.0 In-Reply-To: <20161115095433.GD15424@mwanda> References: <20161115095433.GD15424@mwanda> From: Moritz Fischer Date: Tue, 15 Nov 2016 07:37:10 -0800 Message-ID: Subject: Re: [patch] ARM: socfpga: checking the wrong variable To: Dan Carpenter Cc: Alan Tull , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 26 Hi Dan, On Tue, Nov 15, 2016 at 1:54 AM, Dan Carpenter wrote: > This is a cut and paste bug. We had intended to check "sysmgr". > > Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support") > Signed-off-by: Dan Carpenter Acked-by: Moritz Fischer > > diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c > index 7ab358e..d4eeb74 100644 > --- a/drivers/fpga/altera-fpga2sdram.c > +++ b/drivers/fpga/altera-fpga2sdram.c > @@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev) > } > > sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr"); > - if (IS_ERR(priv->sdrctl)) { > + if (IS_ERR(sysmgr)) { > dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n"); > return PTR_ERR(sysmgr); > } Thanks, Moritz