MIME-Version: 1.0
In-Reply-To: <20161115083736.GA15734@gmail.com>
References: <20161114173946.501528675@infradead.org> <20161114174446.486581399@infradead.org>
 <20161114181655.GA21516@infradead.org> <20161115072855.GB28248@kroah.com> <20161115083736.GA15734@gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 15 Nov 2016 08:42:39 -0800
Message-ID: <CA+55aFz1QBi1Of3UUzc=6HWM7wPe7FaztoxKtCLuneuzu+4=YQ@mail.gmail.com>
Subject: Re: [PATCH] printk, locking/atomics, kref: Introduce new %pAr and
 %pAk format string options for atomic_t and 'struct kref'
To: Ingo Molnar <mingo@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
        Christoph Hellwig <hch@infradead.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Kees Cook <keescook@chromium.org>, Will Deacon <will.deacon@arm.com>,
        elena.reshetova@intel.com, Arnd Bergmann <arnd@arndb.de>,
        Thomas Gleixner <tglx@linutronix.de>, Peter Anvin <hpa@zytor.com>,
        dave@progbits.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 613
Lines: 17

On Tue, Nov 15, 2016 at 12:37 AM, Ingo Molnar <mingo@kernel.org> wrote:
> +atomic variables such atomic_t or struct kref:
> +
> +       %pAr    atomic_t count
> +       %pAk    struct kref count

Not a huge fan. That "r" makes sense to you ("raw" atomic), but it
makes no sense to a user. An atomic isn't "raw" to anybody else. It's
just an atomic.

Also, we have 'atomic64_t", which this doesn't cover at all.

I'd suggest just %pA, %pA64, %pAkref or something. Which leaves us the
choice to add more atomic versions later without having to make up
random one-letter things that make no sense.

           Linus