Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbcKOSBX (ORCPT ); Tue, 15 Nov 2016 13:01:23 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35833 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbcKOSBV (ORCPT ); Tue, 15 Nov 2016 13:01:21 -0500 Reply-To: monstr@monstr.eu Subject: Re: [PATCH 2/2] ARM: zynq: Fix W=1 dtc 1.4 warnings References: <2d42e25d7dd03e562e12e71fd037837737115940.1479218844.git.michal.simek@xilinx.com> <90eca8dfcdcef68ce5fe39f2329c4b61d2662598.1479218844.git.michal.simek@xilinx.com> <20161115154608.GH30999@jcartwri.amer.corp.natinst.com> To: Julia Cartwright , Michal Simek Cc: linux-arm-kernel@lists.infradead.org, S?ren Brinkmann , devicetree@vger.kernel.org, Steffen Trumtrar , linux-kernel@vger.kernel.org, Peter Crosthwaite , Rob Herring , Rob Herring , Mark Rutland , Russell King From: Michal Simek Message-ID: <89b753f1-91ec-c9f9-5a67-17ef91224e9c@monstr.eu> Date: Tue, 15 Nov 2016 19:01:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161115154608.GH30999@jcartwri.amer.corp.natinst.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5Sw0NR6CNd0pNK701FuaTAhuJaKbLjeW5" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3716 Lines: 104 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5Sw0NR6CNd0pNK701FuaTAhuJaKbLjeW5 Content-Type: multipart/mixed; boundary="nkpMka9cga8EI0dQNEVxm2drunhpalC1I"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Julia Cartwright , Michal Simek Cc: linux-arm-kernel@lists.infradead.org, S?ren Brinkmann , devicetree@vger.kernel.org, Steffen Trumtrar , linux-kernel@vger.kernel.org, Peter Crosthwaite , Rob Herring , Rob Herring , Mark Rutland , Russell King Message-ID: <89b753f1-91ec-c9f9-5a67-17ef91224e9c@monstr.eu> Subject: Re: [PATCH 2/2] ARM: zynq: Fix W=1 dtc 1.4 warnings References: <2d42e25d7dd03e562e12e71fd037837737115940.1479218844.git.michal.simek@xilinx.com> <90eca8dfcdcef68ce5fe39f2329c4b61d2662598.1479218844.git.michal.simek@xilinx.com> <20161115154608.GH30999@jcartwri.amer.corp.natinst.com> In-Reply-To: <20161115154608.GH30999@jcartwri.amer.corp.natinst.com> --nkpMka9cga8EI0dQNEVxm2drunhpalC1I Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi, On 15.11.2016 16:46, Julia Cartwright wrote: > On Tue, Nov 15, 2016 at 03:07:27PM +0100, Michal Simek wrote: >> The patch removes these warnings reported by dtc 1.4: >> Warning (unit_address_vs_reg): Node /pmu has a reg or ranges property,= >> but no unit name >> Warning (unit_address_vs_reg): Node /fixedregulator@0 has a unit name,= >> but no reg property >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges >> property, but no unit name >> >> Signed-off-by: Michal Simek >=20 > Reviewed-by: Julia Cartwright >> >> --- >> >> arch/arm/boot/dts/zynq-7000.dtsi | 4 ++-- >> arch/arm/boot/dts/zynq-parallella.dts | 2 +- >> arch/arm/boot/dts/zynq-zc702.dts | 2 +- >> arch/arm/boot/dts/zynq-zc706.dts | 2 +- >> arch/arm/boot/dts/zynq-zed.dts | 2 +- >> arch/arm/boot/dts/zynq-zybo.dts | 2 +- >> 6 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq= -7000.dtsi >> index f47a6c1cc752..402b5bbe3b5b 100644 >> --- a/arch/arm/boot/dts/zynq-7000.dtsi >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi >> @@ -42,14 +42,14 @@ >> }; >> }; >> =20 >> - pmu { >> + pmu@f8891000 { >> compatible =3D "arm,cortex-a9-pmu"; >> interrupts =3D <0 5 4>, <0 6 4>; >> interrupt-parent =3D <&intc>; >> reg =3D < 0xf8891000 0x1000 0xf8893000 0x1000 >; >=20 > Style nit: we should drop the space before/after '<' and '>'; and, > perhaps separate the entries to be a bit more readable: >=20 > reg =3D <0xf8891000 0x1000>, > <0xf8893000 0x1000>; yes we can do it. Do you want to send separate patch for it? Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs --nkpMka9cga8EI0dQNEVxm2drunhpalC1I-- --5Sw0NR6CNd0pNK701FuaTAhuJaKbLjeW5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlgrTW0ACgkQykllyylKDCF43gCglPzQn7wryin+VXgynlu4IYAb gMEAn21fs6ph2/zP19F7DqiWBLOsNsFl =bgir -----END PGP SIGNATURE----- --5Sw0NR6CNd0pNK701FuaTAhuJaKbLjeW5--