Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753975AbcKOS5S (ORCPT ); Tue, 15 Nov 2016 13:57:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40458 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724AbcKOS5Q (ORCPT ); Tue, 15 Nov 2016 13:57:16 -0500 Date: Tue, 15 Nov 2016 13:57:14 -0500 From: Mike Snitzer To: Christoph Hellwig Cc: Ming Lei , Jens Axboe , Linux Kernel Mailing List , linux-block , Linux FS Devel , Alasdair Kergon , "maintainer:DEVICE-MAPPER (LVM)" , Shaohua Li , "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" Subject: Re: [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page Message-ID: <20161115185714.GA17614@redhat.com> References: <1478865957-25252-1-git-send-email-tom.leiming@gmail.com> <1478865957-25252-8-git-send-email-tom.leiming@gmail.com> <20161115185551.GA14816@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161115185551.GA14816@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 15 Nov 2016 18:57:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 349 Lines: 11 On Tue, Nov 15 2016 at 1:55pm -0500, Christoph Hellwig wrote: > > Hi Alasdair, Mike, Christoph and anyone, > > > > Could you give this one a review? > > It looks nice, but I don't understand the code anywhere near well > enough to review it. We'll need someone from the DM to look over it. I'll try to get to it this week.