Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753706AbcKOS7Z (ORCPT ); Tue, 15 Nov 2016 13:59:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43086 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbcKOS7X (ORCPT ); Tue, 15 Nov 2016 13:59:23 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 9868D615A8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 15 Nov 2016 10:59:22 -0800 From: Stephen Boyd To: Vivek Gautam Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, gregkh@linuxfoundation.org, rnayak@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write Message-ID: <20161115185922.GB25626@codeaurora.org> References: <1479218682-15948-1-git-send-email-vivek.gautam@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479218682-15948-1-git-send-email-vivek.gautam@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 487 Lines: 17 On 11/15, Vivek Gautam wrote: > @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev) > static struct nvmem_config econfig = { > .name = "qfprom", > .owner = THIS_MODULE, > - .stride = 4, > + .stride = 1, Are we certain that all qfproms support byte accesses? > .word_size = 1, > .reg_read = qfprom_reg_read, > .reg_write = qfprom_reg_write, -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project