MIME-Version: 1.0
In-Reply-To: <1478902913-143778-1-git-send-email-keescook@chromium.org>
References: <1478902913-143778-1-git-send-email-keescook@chromium.org>
From: Joel Fernandes <joelaf@google.com>
Date: Tue, 15 Nov 2016 11:55:48 -0800
Message-ID: <CAJWu+oqqFQbqLR7s8ho=Y0oeT_PR8OL67S+5t6kQouTefHXiAA@mail.gmail.com>
Subject: Re: [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops
To: Kees Cook <keescook@chromium.org>
Cc: Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 30

Hi Kees,

On Fri, Nov 11, 2016 at 2:21 PM, Kees Cook <keescook@chromium.org> wrote:
> Hi Joel,
>
> I've reorganized a bunch of the logic here. Since pstore is going to need
> the init_przs() logic for multiple pmsg przs, I wanted to get this in and
> make sure I was happy with how it looks. I figured this would reduce our
> round-trip time on reviews. :)
>
> Can you test this series and verify that it works as you're expecting? I've
> validated some basic behavior already, but don't have a good test-case for
> ftrace. What commands do you actually use for testing ftrace? I'd like to
> add something to my local tests.

I normally do the following:

dd if=/dev/urandom | pv | dd of=/dev/null

and in parallel, I do a:
echo 1 > /sys/kernel/debug/pstore/record_ftrace

and then check the throughput; and then reboot the system and do a
read out of /sys/fs/pstore/ ftrace file.

I will try these patches out today and thanks for refactoring the init
prz stuff.

Regards,
Joel