Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934463AbcKOVte (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Nov 2016 16:49:34 -0500
Received: from smtprelay0001.hostedemail.com ([216.40.44.1]:40491 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S932797AbcKOVtc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Nov 2016 16:49:32 -0500
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1461:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3873:3874:4250:4321:5007:6119:6261:7774:7875:8660:8957:10004:10400:10848:10903:10967:11026:11232:11473:11658:11914:12043:12555:12663:12740:12760:13069:13148:13161:13229:13230:13255:13311:13357:13439:14181:14659:14721:21080:21451:30012:30054:30089:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: queen14_532627ddb882e
X-Filterd-Recvd-Size: 2575
Date: Tue, 15 Nov 2016 16:49:29 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Andreas Platschek <andreas.platschek@opentech.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] trace-cmd: Makefile - link all trace-* objects into
 ctracecmd.so
Message-ID: <20161115164929.380e98f3@gandalf.local.home>
In-Reply-To: <1479124543-30911-2-git-send-email-andreas.platschek@opentech.at>
References: <1479124543-30911-1-git-send-email-andreas.platschek@opentech.at>
        <1479124543-30911-2-git-send-email-andreas.platschek@opentech.at>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1593
Lines: 44

On Mon, 14 Nov 2016 11:55:42 +0000
Andreas Platschek <andreas.platschek@opentech.at> wrote:

> Got a few undefined symbols when using the Python interface to trace-cmd,
> the first one was:
> 
> root@wheezy:~/trace-cmd# python tracecmd.py
> Traceback (most recent call last):
>   File "tracecmd.py", line 22, in <module>
>     from ctracecmd import *
> ImportError: /home/andi/working_git/trace-cmd/ctracecmd.so: undefined symbol: get_file_content
> 
> linking the objects that contain those symbols fixes the problem.
> 
> Signed-off-by: Andreas Platschek <andreas.platschek@opentech.at>
> ---
>  Makefile |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 62cb25b..f86cb77 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -344,7 +344,8 @@ TCMD_LIB_OBJS = $(PEVENT_LIB_OBJS) trace-util.o trace-input.o trace-ftrace.o \
>  			trace-output.o trace-record.o trace-recorder.o \
>  			trace-restore.o trace-usage.o trace-blk-hack.o \
>  			kbuffer-parse.o event-plugin.o trace-hooks.o \
> -			trace-msg.o
> +			trace-msg.o trace-stat.o trace-listen.o trace-stream.o \
> +			trace-read.o trace-profile.o trace-hash.o

Actually, I can't do this. The files in the library are licensed under
LGPL, but these files you added are all GPL.

There's a reason I separated them as such. I guess we may be able to
move things out of the files if they are properly authored. That is, if
I wrote them. Some code I took and used in trace-cmd came from GPL v2
code, so those must remain GPL v2.

-- Steve

>  
>  PLUGIN_OBJS =
>  PLUGIN_OBJS += plugin_jbd2.o