Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752917AbcKPGPt (ORCPT ); Wed, 16 Nov 2016 01:15:49 -0500 Received: from ozlabs.org ([103.22.144.67]:55251 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbcKPGPr (ORCPT ); Wed, 16 Nov 2016 01:15:47 -0500 From: Michael Ellerman To: Tomi Valkeinen , Linus Torvalds Cc: linux-fbdev , "linux-kernel\@vger.kernel.org" , Mathieu Malaterre Subject: Re: [GIT PULL] fbdev fixes for 4.9 In-Reply-To: References: User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 16 Nov 2016 17:15:40 +1100 Message-ID: <87r36cx84z.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 37 Tomi Valkeinen writes: > [ Unknown signature status ] > On 14/11/16 18:25, Linus Torvalds wrote: >> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen wrote: >>> >>> Please pull two fbdev fixes for 4.9. >> >> No. >> >> This has obviously never even been test-compiled. It introduces two >> new annoying warnings. > > Sorry about that. I dropped the patch for now and here's a new pull request. > > I did test compile, and I would have noticed errors but I missed the warnings > (I blame the flu...). I need to improve my testing methods, but I couldn't find > a way to add -Werror to kernel builds. You can turn it on per-directory, eg: diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile index ee8c81405a7f..2ee96810d26d 100644 --- a/drivers/video/fbdev/Makefile +++ b/drivers/video/fbdev/Makefile @@ -4,6 +4,8 @@ # Each configuration option enables a list of files. +subdir-ccflags-y := -Werror + obj-y += core/ obj-$(CONFIG_FB_MACMODES) += macmodes.o cheers