Message-ID: <582C1041.7040809@gmail.com>
Date: Wed, 16 Nov 2016 07:52:33 +0000
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Marek Vasut <marek.vasut@gmail.com>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>
CC: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: nandsim: fix error check
References: <1479251395-3100-1-git-send-email-sudipm.mukherjee@gmail.com> <0ad0b3d4-bde6-57ab-6856-de771ade3c32@gmail.com>
In-Reply-To: <0ad0b3d4-bde6-57ab-6856-de771ade3c32@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1101
Lines: 30

On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote:
>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or
>> a pointer on success. They do not return the error value with ERR_PTR.
>> So we should not check the return with IS_ERR_OR_NULL, instead we
>> should just check for NULL.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>> ---
>>   drivers/mtd/nand/nandsim.c | 9 +++------
>>   1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
>> index c76287a..9b0d79a 100644
>> --- a/drivers/mtd/nand/nandsim.c
>> +++ b/drivers/mtd/nand/nandsim.c
>> @@ -525,15 +525,13 @@ static int nandsim_debugfs_create(struct nandsim *dev)
>>   {
>>   	struct nandsim_debug_info *dbg = &dev->dbg;
>>   	struct dentry *dent;
>> -	int err;
>> +	int err = -ENODEV;
>
> Why don't you just nuke the err altogether and just return -ENODEV ?

That was the first version which i made and discarded before sending. I 
will go and find it now.

Regards
Sudip