Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936138AbcKPJXR (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Nov 2016 04:23:17 -0500
Received: from mail-oi0-f66.google.com ([209.85.218.66]:34196 "EHLO
        mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752360AbcKPJXN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Nov 2016 04:23:13 -0500
MIME-Version: 1.0
X-Originating-IP: [217.173.44.24]
In-Reply-To: <1479228894-10533-1-git-send-email-quorum.laval@gmail.com>
References: <1479228894-10533-1-git-send-email-quorum.laval@gmail.com>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Wed, 16 Nov 2016 10:23:11 +0100
Message-ID: <CAJfpegsHvz2G8n_Nw8v2aoophDQCBvcB7v1mkWonifsUqJ7HhA@mail.gmail.com>
Subject: Re: [PATCH 1/2] ovl: use kernel facility for copying attributes
To: Quorum Laval <quorum.laval@gmail.com>
Cc: "linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 370
Lines: 10

On Tue, Nov 15, 2016 at 5:54 PM, Quorum Laval <quorum.laval@gmail.com> wrote:
> Replace ovl_copyattr() by fsstack_copy_attr_all() and drop the definition of
> the former.

This isn't trivially correct, fsstack_copy_attr_all() copies more than
ovl_copyattr().   We need a better explanation for why it is correct
to copy all the other attributes as well.

Thanks,
Miklos