Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933603AbcKPKmX (ORCPT ); Wed, 16 Nov 2016 05:42:23 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:64016 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbcKPKmU (ORCPT ); Wed, 16 Nov 2016 05:42:20 -0500 Subject: Re: [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node To: Alexandre Bailon , , , References: <1478188752-22447-1-git-send-email-abailon@baylibre.com> <1478188752-22447-5-git-send-email-abailon@baylibre.com> <0c94c5e0-9d2c-fff5-1213-2fb2adb20ab0@ti.com> CC: , , , From: Sekhar Nori Message-ID: Date: Wed, 16 Nov 2016 16:11:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 37 On Wednesday 16 November 2016 04:05 PM, Alexandre Bailon wrote: > On 11/15/2016 11:46 AM, Sekhar Nori wrote: >> On Thursday 03 November 2016 09:29 PM, Alexandre Bailon wrote: >>> This adds the device tree node for the usb otg >>> controller present in the da850 family of SoC's. >>> This also enables the otg usb controller for the lcdk board. >>> >>> Signed-off-by: Alexandre Bailon >>> --- >>> arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ >>> arch/arm/boot/dts/da850.dtsi | 15 +++++++++++++++ >>> 2 files changed, 23 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts >>> index 7b8ab21..9f5040c 100644 >>> --- a/arch/arm/boot/dts/da850-lcdk.dts >>> +++ b/arch/arm/boot/dts/da850-lcdk.dts >>> @@ -158,6 +158,14 @@ >>> rx-num-evt = <32>; >>> }; >>> >>> +&usb_phy { >>> + status = "okay"; >>> + }; >> >> As mentioned by David already, this node needs to be removed. Please > I have missed it. But why should I remove it? > Without it, usb otg won't work. Grr, I replied to the wrong hunk. The part in da850-lcdk.dts needs to be preserved (but please fix the indentation on the closing brace). The part in da850.dtsi needs to be removed as it is already merged. Thanks, Sekhar