Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932657AbcKPMQ1 (ORCPT ); Wed, 16 Nov 2016 07:16:27 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36426 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932229AbcKPMQW (ORCPT ); Wed, 16 Nov 2016 07:16:22 -0500 Date: Wed, 16 Nov 2016 13:16:18 +0100 From: Jiri Pirko To: Greentime Hu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: faraday: To support device tree usage. Message-ID: <20161116121618.GC1791@nanopsycho.orion> References: <1479285795-3105-1-git-send-email-green.hu@gmail.com> <20161116115343.GB1791@nanopsycho.orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1635 Lines: 52 Wed, Nov 16, 2016 at 01:08:57PM CET, green.hu@gmail.com wrote: >You are right. I didn't notice that. I should use ftmac100. Don't top-post please. > >On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko wrote: >> Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@gmail.com wrote: >>>To support device tree usage for ftmac100. >>> >>>Signed-off-by: Greentime Hu >>>--- >>> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>>diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c >>>index dce5f7b..81dd9e1 100644 >>>--- a/drivers/net/ethernet/faraday/ftmac100.c >>>+++ b/drivers/net/ethernet/faraday/ftmac100.c >>>@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev) >>> return 0; >>> } >>> >>>+static const struct of_device_id mac_of_ids[] = { >> >> Prefix of everything in this file is "ftmac100", yet here, you use >> "mac". I wonder why?!? >> >> >> >>>+ { .compatible = "andestech,atmac100" }, >>>+ { } >>>+}; >>>+ >>> static struct platform_driver ftmac100_driver = { >>> .probe = ftmac100_probe, >>> .remove = __exit_p(ftmac100_remove), >>> .driver = { >>> .name = DRV_NAME, >>>+ .of_match_table = mac_of_ids >>> }, >>> }; >>> >>>@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void) >>> MODULE_AUTHOR("Po-Yu Chuang "); >>> MODULE_DESCRIPTION("FTMAC100 driver"); >>> MODULE_LICENSE("GPL"); >>>+MODULE_DEVICE_TABLE(of, mac_of_ids); >>>-- >>>1.7.9.5 >>>