Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932783AbcKPMRE (ORCPT ); Wed, 16 Nov 2016 07:17:04 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58184 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbcKPMQ7 (ORCPT ); Wed, 16 Nov 2016 07:16:59 -0500 Date: Wed, 16 Nov 2016 12:16:44 +0000 From: Mark Brown To: Venkat Reddy Talla Cc: lee.jones@linaro.org, lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ldewangan@nvidia.com, svelpula@nvidia.com Message-ID: <20161116121644.4cfuapcqcsqokr32@sirena.org.uk> References: <1479297161-7705-1-git-send-email-vreddytalla@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="54scu5ljx65iqrk3" Content-Disposition: inline In-Reply-To: <1479297161-7705-1-git-send-email-vreddytalla@nvidia.com> X-Cookie: Reality does not exist -- yet. User-Agent: NeoMutt/20161014 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: max77620: add support to configure MPOK X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 39 --54scu5ljx65iqrk3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 16, 2016 at 05:22:40PM +0530, Venkat Reddy Talla wrote: > Adding support to configure regulator POK mapping bit > to control nRST_IO and GPIO1 POK function. This leaves me none the wiser as to what this is supposed to do... > + if (chip->chip_id == MAX20024) { Please use switch statements so we can add new cases without rewriting everything. > + ret = of_property_read_u32(np, "maxim,power-ok-control", &pval); > + rpdata->power_ok = (!ret) ? pval : -1; > + Please write normal logic statements, people need to be able to read the code and understand what it does. --54scu5ljx65iqrk3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAABCAAGBQJYLE4rAAoJECTWi3JdVIfQ2rcH/2etzGzNAk+xVL8m4WZpDmpe 0Wpc3itGXPf8zHANhCprig2nruVqU7cy21nlEzA/O8y5/Fw23LgIB7mH2zzeaHk/ 0C4EwH9D+axt9sFFxwrrZpWWSzBBOXgbvOO0ax1sN2Wh8Etn+f9ELFZuWnS+gy6W M2/qExbJAmsT/AavvSOZSBoNVPfUJRKYFd1t1wlsninYjKu8ctnzH1g9iHf5XWHw hn8fZfo+VZTnUb1RYFLLSpoHntVCasFJ4lEjeHcGtvAH010QNvntirTVrPVGUmso UcFFU2yroCAGC8+KW5RHqJNPJjjDHswaemL0rQRU1bgemJh+aPt366S3nDHFMlA= =6qVd -----END PGP SIGNATURE----- --54scu5ljx65iqrk3--