Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753244AbcKPM3C (ORCPT ); Wed, 16 Nov 2016 07:29:02 -0500 Received: from gloria.sntech.de ([95.129.55.99]:58844 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652AbcKPM3A (ORCPT ); Wed, 16 Nov 2016 07:29:00 -0500 From: Heiko Stuebner To: Jacob Chen Cc: andy.yan@rock-chips.com, linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jacob Chen Subject: Re: [PATCH 2/2] ARM: dts: rockchip: enable sdmmc for rk1108-evb Date: Wed, 16 Nov 2016 13:28:42 +0100 Message-ID: <5071766.aON0S2k73p@phil> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1479024799-29198-2-git-send-email-jacob-chen@iotwrt.com> References: <1479024799-29198-1-git-send-email-jacob-chen@iotwrt.com> <1479024799-29198-2-git-send-email-jacob-chen@iotwrt.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1300 Lines: 54 Am Sonntag, 13. November 2016, 16:13:19 CET schrieb Jacob Chen: > From: Jacob Chen > > This patch add sdmmc support for rk1108-evb, now I can load the rootfs > from sdmmc. > > Signed-off-by: Jacob Chen > --- > arch/arm/boot/dts/rk1108-evb.dts | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boot/dts/rk1108-evb.dts > b/arch/arm/boot/dts/rk1108-evb.dts index 3956cff..cea26e5 100644 > --- a/arch/arm/boot/dts/rk1108-evb.dts > +++ b/arch/arm/boot/dts/rk1108-evb.dts > @@ -56,6 +56,18 @@ > }; > }; > > +&sdmmc { > + bus-width = <4>; > + cap-mmc-highspeed; > + cap-sd-highspeed; > + card-detect-delay = <200>; > + disable-wp; > + num-slots = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>; > + status = "okay"; > +}; > + > &uart0 { > status = "okay"; > }; > @@ -67,3 +79,12 @@ > &uart2 { > status = "okay"; > }; > + > +&pinctrl { > + > + sdmmc { > + sdmmc_pwr: sdmmc-pwr { > + rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_pull_up_drv_4ma>; > + }; the above is unsued, and in general please use a fixed regulator as vmmc, as all other Rockchip boards do already, so that the mmc core can handle it itself. Thanks Heiko