Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932559AbcKPN3J (ORCPT ); Wed, 16 Nov 2016 08:29:09 -0500 Received: from regular1.263xmail.com ([211.150.99.140]:59725 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112AbcKPN3H (ORCPT ); Wed, 16 Nov 2016 08:29:07 -0500 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-RL-SENDER: wulf@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wulf@rock-chips.com X-UNIQUE-TAG: <71cc131ae1621bd479d5b7be7dc5c5ca> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: linux-next: build warning after merge of the phy-next tree To: Stephen Rothwell , Kishon Vijay Abraham I References: <20161116140004.465a98af@canb.auug.org.au> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org From: wlf Message-ID: Date: Wed, 16 Nov 2016 21:28:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116140004.465a98af@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 31 Hi Stephen, 在 2016年11月16日 11:00, Stephen Rothwell 写道: > Hi Kishon, > > After merging the phy-next tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work': > drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (tmout) { > ^ > > Introduced by commit > > 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399") The variable "tmout" is initialized in the prior code "case USB_CHG_STATE_WAIT_FOR_DCD", and this case will be executed before "if (tmout)", so I think it's a mis-warning for some special compiler. Could you provide me some suggestion about this warning? Should I upload a new patch to fix this compiler mis-warning or just ignore it ? :-) Best regards, wulf >