Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753332AbcKPNrV (ORCPT ); Wed, 16 Nov 2016 08:47:21 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:41671 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbcKPNrR (ORCPT ); Wed, 16 Nov 2016 08:47:17 -0500 Date: Wed, 16 Nov 2016 14:47:15 +0100 From: Andrew Lunn To: Greentime Hu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: faraday: To support device tree usage. Message-ID: <20161116134715.GE19962@lunn.ch> References: <1479285795-3105-1-git-send-email-green.hu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479285795-3105-1-git-send-email-green.hu@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 28 On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote: > To support device tree usage for ftmac100. > > Signed-off-by: Greentime Hu > --- > drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c > index dce5f7b..81dd9e1 100644 > --- a/drivers/net/ethernet/faraday/ftmac100.c > +++ b/drivers/net/ethernet/faraday/ftmac100.c > @@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id mac_of_ids[] = { > + { .compatible = "andestech,atmac100" }, > + { } andestech is not in Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a separate patch adding it. Humm, why andestech? Why not something based around faraday technology? Andrew