Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932896AbcKPNxf (ORCPT ); Wed, 16 Nov 2016 08:53:35 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:41700 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752955AbcKPNxb (ORCPT ); Wed, 16 Nov 2016 08:53:31 -0500 Date: Wed, 16 Nov 2016 14:53:29 +0100 From: Andrew Lunn To: Greentime Hu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jiri@resnulli.us Subject: Re: [PATCH v2] net: ethernet: faraday: To support device tree usage. Message-ID: <20161116135329.GG19962@lunn.ch> References: <1479297826-4335-1-git-send-email-green.hu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479297826-4335-1-git-send-email-green.hu@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 22 On Wed, Nov 16, 2016 at 08:03:46PM +0800, Greentime Hu wrote: > Signed-off-by: Greentime Hu > --- > drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c > index dce5f7b..5d70ee9 100644 > --- a/drivers/net/ethernet/faraday/ftmac100.c > +++ b/drivers/net/ethernet/faraday/ftmac100.c > @@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id ftmac100_of_ids[] = { > + { .compatible = "andestech,atmac100" }, Please see my comment to v1. You are also supposed to add a binding document. Andrew