Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932950AbcKPO1g (ORCPT ); Wed, 16 Nov 2016 09:27:36 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:35256 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652AbcKPO1d (ORCPT ); Wed, 16 Nov 2016 09:27:33 -0500 MIME-Version: 1.0 In-Reply-To: <20161116134715.GE19962@lunn.ch> References: <1479285795-3105-1-git-send-email-green.hu@gmail.com> <20161116134715.GE19962@lunn.ch> From: Greentime Hu Date: Wed, 16 Nov 2016 22:26:52 +0800 Message-ID: Subject: Re: [PATCH] net: ethernet: faraday: To support device tree usage. To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1171 Lines: 30 On Wed, Nov 16, 2016 at 9:47 PM, Andrew Lunn wrote: > On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote: >> To support device tree usage for ftmac100. >> >> Signed-off-by: Greentime Hu >> --- >> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c >> index dce5f7b..81dd9e1 100644 >> --- a/drivers/net/ethernet/faraday/ftmac100.c >> +++ b/drivers/net/ethernet/faraday/ftmac100.c >> @@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev) >> return 0; >> } >> >> +static const struct of_device_id mac_of_ids[] = { >> + { .compatible = "andestech,atmac100" }, >> + { } > > andestech is not in > Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a > separate patch adding it. OK. I will provide another patch to add andestech. > Humm, why andestech? Why not something based around faraday > technology? It is because we use the same ftmac100 IP provided from faraday technology but I am now using it in andestech SoC.