Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261907AbTEHRfD (ORCPT ); Thu, 8 May 2003 13:35:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261916AbTEHRfD (ORCPT ); Thu, 8 May 2003 13:35:03 -0400 Received: from hypatia.llnl.gov ([134.9.11.73]:1152 "EHLO hypatia.llnl.gov") by vger.kernel.org with ESMTP id S261907AbTEHRfC convert rfc822-to-8bit (ORCPT ); Thu, 8 May 2003 13:35:02 -0400 Content-Type: text/plain; charset=US-ASCII From: Dave Peterson Organization: Lawrence Livermore National Laboratory To: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] fixes for linked list bugs in block I/O code Date: Thu, 8 May 2003 10:47:24 -0700 User-Agent: KMail/1.4.1 Cc: linux-kernel@vger.kernel.org, axboe@suse.de, davej@suse.de References: In-Reply-To: MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Message-Id: <200305081047.24908.dsp@llnl.gov> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 18 On Wednesday 07 May 2003 06:17 pm, Bartlomiej Zolnierkiewicz wrote: > > > Yes, but bio->bi_next is a NULL already. > > > > I think assuming this is bad programming form. You are assuming that > > the memory allocator zeros out newly allocated memory. Though your > > No, it is not memory allocator but block layer. > Look at bio_init(), there is bio->bi_next = NULL explicitly. Ok, I agree: the patch is not needed for 2.5 (although I think it still makes sense for 2.4.20). Thanks for the correction. -Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/