Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959AbcKPPNu (ORCPT ); Wed, 16 Nov 2016 10:13:50 -0500 Received: from mga14.intel.com ([192.55.52.115]:18215 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752206AbcKPPNr (ORCPT ); Wed, 16 Nov 2016 10:13:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,500,1473145200"; d="scan'208";a="192145292" Message-ID: <1479309042.24056.40.camel@linux.intel.com> Subject: Re: [PATCH 4/4] Update device tree Synopsys DW DMAC documentation From: Andy Shevchenko To: Eugeniy Paltsev , devicetree@vger.kernel.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, vireshk@kernel.org, dan.j.williams@intel.com, vinod.koul@intel.com, dmaengine@vger.kernel.org, linux-snps-arc@lists.infradead.org Date: Wed, 16 Nov 2016 17:10:42 +0200 In-Reply-To: <1479304615-11360-5-git-send-email-Eugeniy.Paltsev@synopsys.com> References: <1479304615-11360-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <1479304615-11360-5-git-send-email-Eugeniy.Paltsev@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2541 Lines: 89 On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote: >  * Rename is_private to is-private as ordered by DT policy. >  The change leaves the support for the old format. > >  * Add is-memcpu property, so it is possible to >  enable memory-to-memory transfers support via DT. > >  * Add hw-llp property, so it is possible to enable >  hardware multi block transfers support via DT. > >  Fix white spaces. > > Signed-off-by: Eugeniy Paltsev > --- >  Documentation/devicetree/bindings/dma/snps-dma.txt | 10 ++++++++-- >  1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt > b/Documentation/devicetree/bindings/dma/snps-dma.txt > index 0f55832..d41d960 100644 > --- a/Documentation/devicetree/bindings/dma/snps-dma.txt > +++ b/Documentation/devicetree/bindings/dma/snps-dma.txt > @@ -20,13 +20,19 @@ Required properties: >  Deprecated properties: >  - data_width: Maximum data width supported by hardware per AHB master >    (0 - 8bits, 1 - 16bits, ..., 5 - 256bits) > +- is_private: The device channels should be marked as private and not > for by the > +  general purpose DMA channel allocator. False if not passed. This... >   >   >  Optional properties: >  - interrupt-parent: Should be the phandle for the interrupt > controller >    that services interrupts for this device > -- is_private: The device channels should be marked as private and not > for by the > +- is-private: The device channels should be marked as private and not > for by the >    general purpose DMA channel allocator. False if not passed. ...and this is a part of patch 1. > +- is-memcpu: The device channels do support memory-to-memory memcpy > transfers. > False > +  if not passed. > +- hw-llp: Multi block transfers supported by hardware per AHB master. > +  0 (default): not supported, 1: supported. Overall, since we are going to expose some properties to the Device Tree I would really think twice about naming. Better if we reuse something existing already. So, what I can see is dmacap,private dmacap,memcpy Here is a selling point as well, i.e. standardization. 'hw-llp' sounds too tricky, perhaps 'multi-block' is better and could be re-used. >   >  Example: >   > @@ -56,7 +62,7 @@ The four cells in order are: >  4. Peripheral master for transfers on allocated channel >   >  Example: > - > + No, no need to touch this. -- Andy Shevchenko Intel Finland Oy