Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932658AbcKPP4V (ORCPT ); Wed, 16 Nov 2016 10:56:21 -0500 Received: from mail-it0-f54.google.com ([209.85.214.54]:36389 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753067AbcKPP4R (ORCPT ); Wed, 16 Nov 2016 10:56:17 -0500 Date: Wed, 16 Nov 2016 08:56:13 -0700 From: Mathieu Poirier To: yuantian.tang@nxp.com Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] ahci: qoriq: report warning when ecc register is missing Message-ID: <20161116155613.GA1228@linaro.org> References: <1479265879-48840-1-git-send-email-yuantian.tang@nxp.com> <1479265879-48840-2-git-send-email-yuantian.tang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479265879-48840-2-git-send-email-yuantian.tang@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 50 On Wed, Nov 16, 2016 at 11:11:19AM +0800, yuantian.tang@nxp.com wrote: > From: Tang Yuantian > > For ls1021a and ls1046a socs, sata ecc must be disabled. > If ecc register is not found in sata node in dts, report > a warning. Hi Yuantian, What happens if sata ecc is _not_ disaled on those socs? Can the driver still work? If not then it is probably a better idea to return an error code that can prevent the driver from initialising. Thanks, Mathieu > > Signed-off-by: Tang Yuantian > --- > drivers/ata/ahci_qoriq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c > index 45c88de..66eb4b5 100644 > --- a/drivers/ata/ahci_qoriq.c > +++ b/drivers/ata/ahci_qoriq.c > @@ -158,6 +158,7 @@ static int ahci_qoriq_phy_init(struct ahci_host_priv *hpriv) > > switch (qpriv->type) { > case AHCI_LS1021A: > + WARN_ON(!qpriv->ecc_addr); > writel(SATA_ECC_DISABLE, qpriv->ecc_addr); > writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1); > writel(LS1021A_PORT_PHY2, reg_base + PORT_PHY2); > @@ -185,6 +186,7 @@ static int ahci_qoriq_phy_init(struct ahci_host_priv *hpriv) > break; > > case AHCI_LS1046A: > + WARN_ON(!qpriv->ecc_addr); > writel(LS1046A_SATA_ECC_DIS, qpriv->ecc_addr); > writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1); > writel(AHCI_PORT_TRANS_CFG, reg_base + PORT_TRANS); > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel