Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933410AbcKPQSK (ORCPT ); Wed, 16 Nov 2016 11:18:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:46911 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbcKPQSI (ORCPT ); Wed, 16 Nov 2016 11:18:08 -0500 Date: Wed, 16 Nov 2016 17:18:02 +0100 From: David Sterba To: Shailendra Verma Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Shailendra Verma , linux-kernel@vger.kernel.org, vidushi.koul@samsung.com Subject: Re: [PATCH] Fs: Btrfs - Improvement in code readability when Message-ID: <20161116161802.GV12522@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Shailendra Verma , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Shailendra Verma , linux-kernel@vger.kernel.org, vidushi.koul@samsung.com References: <1478771261-1020-1-git-send-email-shailendra.v@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478771261-1020-1-git-send-email-shailendra.v@samsung.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 483 Lines: 10 On Thu, Nov 10, 2016 at 03:17:41PM +0530, Shailendra Verma wrote: > From: "Shailendra Verma" > > There is no need to call kfree() if memdup_user() fails, as no memory > was allocated and the error in the error-valued pointer should be returned. > > Signed-off-by: Shailendra Verma Queued for 4.10, I've edited the subject line as it's very descriptive. ("btrfs: return early from failed memory allocations in ioctl handlers")