Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932309AbcKPQ4A (ORCPT ); Wed, 16 Nov 2016 11:56:00 -0500 Received: from mail-db5eur01on0068.outbound.protection.outlook.com ([104.47.2.68]:52180 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752805AbcKPQz5 (ORCPT ); Wed, 16 Nov 2016 11:55:57 -0500 From: york sun To: "yanjiang.jin@windriver.com" , "morbidrsa@gmail.com" , "bp@alien8.de" , "mchehab@kernel.org" , "scottwood@nxp.com" CC: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jinyanjing@gmail.com" Subject: Re: [PATCH] edac: mpc85xx: implement "remove" for mpc85xx_pci_err_driver Thread-Topic: [PATCH] edac: mpc85xx: implement "remove" for mpc85xx_pci_err_driver Thread-Index: AQHSP9Ju3ZwuH4NGK0mP9EsxBh/lUg== Date: Wed, 16 Nov 2016 16:55:39 +0000 Message-ID: References: <1479277574-26214-1-git-send-email-yanjiang.jin@windriver.com> Reply-To: york sun Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=york.sun@nxp.com; x-originating-ip: [192.88.158.246] x-microsoft-exchange-diagnostics: 1;AM4PR0401MB1729;7:GS69Tcn6R4DFa1P6jdMDu3hjEo9Jq0RFbgKwSTO/0+wLFomb2ZqMRu2akVhdirBx90Wm5NowoZb/gVZLM1NNo+CjO+NprxRrPHBaeA2UvXIBvCwKVAd7NctE3gJzRhRfvtRB8tnoVRq8+Uej2nd9Tas6Uzpyid8Hf6fQwXmUpqIvtJImdqc95TKWSbGI09jxnS1RMGKtQ/D8MPsEQMpCEHREvsmbzijbtH8wEc2kQ9sGJOTQ0tebEVJATw1TsahZWfmI9kLdTUDYoYRSzLZd1sMqQDCwfElNee/1gH99r/OvLX/hQXPvAif0Yc2SZXdYANp9Jl+Z7OOFD1nRuIJkFbdhnWxth3SLRNbGBRzyJCI= x-ms-office365-filtering-correlation-id: 9ddf2144-0aec-4c6c-3d32-08d40e41651d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM4PR0401MB1729; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6060326)(6045074)(6040281)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6046074)(6041223)(6061324);SRVR:AM4PR0401MB1729;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB1729; x-forefront-prvs: 01283822F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(43544003)(377454003)(189002)(199003)(24454002)(6116002)(106356001)(3846002)(7846002)(2906002)(106116001)(66066001)(229853002)(305945005)(105586002)(33656002)(102836003)(7736002)(86362001)(2201001)(8676002)(53806999)(86152002)(76176999)(97736004)(50986999)(54356999)(8936002)(4326007)(43066003)(76576001)(81166006)(74316002)(3450700001)(5660300001)(5001770100001)(3660700001)(6636002)(189998001)(81156014)(3280700002)(87936001)(122556002)(2900100001)(77096005)(101416001)(7696004)(68736007)(9686002)(6506003)(2501003)(15760500001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0401MB1729;H:AM4PR0401MB1732.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2016 16:55:39.7259 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB1729 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAGGu95i004334 Content-Length: 498 Lines: 17 On 11/15/2016 10:26 PM, yanjiang.jin@windriver.com wrote: > From: Yanjiang Jin > > Tested on a T4240QDS board. > > If we execute the below steps without this patch: > > 1. modprobe mpc85xx_edac [The first insmod, everything is well.] > 2. modprobe -r mpc85xx_edac > 3. modprobe mpc85xx_edac [insmod again, error happens.] > Glad you take care of it. I worked on the memory part and noticed this issue, but it seems not get much attention when I brought it up. York