Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933826AbcKPStv (ORCPT ); Wed, 16 Nov 2016 13:49:51 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:29439 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932995AbcKPSts (ORCPT ); Wed, 16 Nov 2016 13:49:48 -0500 X-IronPort-AV: E=Sophos;i="5.31,649,1473145200"; d="scan'208";a="336220824" X-IronPort-AV: E=McAfee;i="5700,7163,8350"; a="1239351446" Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() From: Kalle Valo In-Reply-To: <1479190014-11297-1-git-send-email-bjorn.andersson@linaro.org> References: <1479190014-11297-1-git-send-email-bjorn.andersson@linaro.org> To: Bjorn Andersson CC: Eugene Krasnikov , Kalle Valo , Andy Gross , , , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.3 Message-ID: Date: Wed, 16 Nov 2016 19:49:38 +0100 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01F.na.qualcomm.com (10.85.0.32) To euamsexm01a.eu.qualcomm.com (10.251.127.40) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 29 Bjorn Andersson wrote: > The correct include file for getting errno constants and ERR_PTR() is > linux/err.h, rather than linux/errno.h, so fix the include. > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") > Acked-by: Andy Gross > Signed-off-by: Bjorn Andersson For some reason this fails to compile now. Can you take a look, please? ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 5 patches set to Changes Requested. 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client 9429037 [v5,3/5] wcn36xx: Implement firmware assisted scan 9429043 [v5,4/5] wcn36xx: Implement print_reg indication 9429023 [v5,5/5] wcn36xx: Don't use the destroyed hal_mutex -- https://patchwork.kernel.org/patch/9429045/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches