Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753980AbcKPTtt (ORCPT ); Wed, 16 Nov 2016 14:49:49 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:34637 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbcKPTtr (ORCPT ); Wed, 16 Nov 2016 14:49:47 -0500 MIME-Version: 1.0 In-Reply-To: <20161115223902.GA8347@juliacomputing.com> References: <20161115223902.GA8347@juliacomputing.com> From: Linus Walleij Date: Wed, 16 Nov 2016 20:49:45 +0100 Message-ID: Subject: Re: [PATCH v2] gpio: Remove GPIO_DEVRES option To: Keno Fischer Cc: "linux-kernel@vger.kernel.org" , Alexandre Courbot , "linux-gpio@vger.kernel.org" , jdike@addtoit.com, Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net, Shawn Guo , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 18 On Tue, Nov 15, 2016 at 11:39 PM, Keno Fischer wrote: > This option was added in 6a89a314ab107a12af08c71420c19a37a30fc2d3 to allow use > of the devm_gpio_* functions without CONFIG_GPIOLIB. However, only a few months > later in b69ac52449c658b7ac40034dc3c5f5f4a71a723d, CONFIG_GPIOLIB, was added > as a dependency, defeating the original purpose of this option. Instead of > that patch, the original commit could have just been reverted (and in fact > was partially so in 403c1d0be5ccbd750d25c59d8358843a81e52e3b). Further, > since this option has a dependency on HAS_IOMEM, even though it does not > require it, it causes build failures when !HAS_IOMEM (e.g. in a uml build). > Fix that by completely removing the option, in essence completing the > reversion of the original commit. I split up this terse commit message a bit and added your Signed-off-by and applied for fixes. Yours, Linus Walleij