MIME-Version: 1.0
In-Reply-To: <295ab33e-45da-af64-6716-c8f387a0cb20@mellanox.com>
References: <1479315472-5245-1-git-send-email-cmetcalf@mellanox.com>
 <CALAqxLVK31SNp6Z+6GL1YHzxY44-ghG3C6b0kqi3pyOX63-_tA@mail.gmail.com>
 <bf36c76f-b26f-8d17-b951-f6b919845172@mellanox.com> <CALAqxLXV39Zt0Qp7fnwfR_PEnk4QVEYBfZ8e7k_fUtbT=VgKEw@mail.gmail.com>
 <295ab33e-45da-af64-6716-c8f387a0cb20@mellanox.com>
From: John Stultz <john.stultz@linaro.org>
Date: Wed, 16 Nov 2016 12:00:56 -0800
Message-ID: <CALAqxLVTUkx4x6z=AmqWruhfX9L6R_MVZd+_uiGOoQU-fV-K-A@mail.gmail.com>
Subject: Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits
To: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Salman Qazi <sqazi@google.com>,
        Paul Turner <pjt@google.com>, Tony Lindgren <tony@atomide.com>,
        Steven Miao <realmz6@gmail.com>, lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1553
Lines: 40

On Wed, Nov 16, 2016 at 11:56 AM, Chris Metcalf <cmetcalf@mellanox.com> wrote:
> On 11/16/2016 2:45 PM, John Stultz wrote:
>>
>> On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf <cmetcalf@mellanox.com>
>> wrote:
>>>
>>> diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
>>> index 08398182f56e..5444429884b8 100644
>>> --- a/include/linux/clocksource.h
>>> +++ b/include/linux/clocksource.h
>>> @@ -171,6 +171,10 @@ static inline u32 clocksource_hz2mult(u32 hz, u32
>>> shift_constant)
>>>    *
>>>    * Converts cycles to nanoseconds, using the given mult and shift.
>>>    *
>>> + * The code is optimized for performance and not intended to work
>>> + * with absolute clocksource cycles, as it will easily overflow,
>>> + * but just intended for relative (delta) clocksource cycles.
>>> + *
>>>    * XXX - This could use some mult_lxl_ll() asm optimization
>>
>> Just as a heads up, it seems your working against an older kernel, as
>> this didn't apply. Its simple enough to fix up, so I'll do so, but in
>> the future, please submit patches against something close to Linus
>> HEAD.
>
>
> Oops, sorry; it wasn't version skew (I'm at v4.9-rc4) but whitespace damage.
> I assumed if I just pasted the patch into Thunderbird it would work, since
> it had
> no tabs.  But bizarrely, if I look at the patch in the mailer, it shows a
> two-space
> prefix, but when I save the email to a file, it has a three-space prefix.
> WTF?

Yea. Not many mailers can be trusted with sending patches. I'd
recommend git-send-email. :)

thanks
-john